Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul release CI jobs to automate changelog #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alerque
Copy link

@alerque alerque commented Jun 25, 2021

Given your recent AUR comment:

The CI makes a draft release. I hate automated releases and it lets me write the changelog in before publishing.

I couldn't resist. Marking automated releases as drafts until hand checked and everything looks copacetic I can understand. Writing release notes by hand when you have a changelog file anyway I cannot.

The actual changelog is relatively simple:

$ sed -ne '/v1.7.3/,/^## /{/^## /d;p}' CHANGELOG.md | sed -e '1d;$d'

As a post-script, allow me to note that your workflows look overly convoluted to me. I'm pretty sure we could get the same job done in a much less round-about way. The actions you are using for this are clumsy and not even supported any more (at least one of them is completely deprecated by GitHub officially). Would you be open to accepting an overhaul of the entire workflow process to simplify all the value passing / stages / artifact push & pulls / etc.?

@Morganamilo
Copy link
Owner

I hate the CI and hate github actions so go ahead.

The change to the tag format though is wrong and I don't know why you've changed it.

Also the sed is wrong and doesn't include the changelog or version header.

@Morganamilo
Copy link
Owner

Also if you can get 32 bit builds working that would be nice too :P

@jclds139
Copy link
Contributor

I updated the existing workflow process to get 32-bit arm builds working in #723, so that can at least give you a reference to include them in your overhaul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants