Resolve versions when looking for unused packages #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKasmy
force-pushed
the
fix/resolve-versions-in-orphan-check
branch
from
bddf668 to
44b7420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1335 by keeping track of versions of provided dependencies and keeping only those providers that actually satisfy the package and version dependencies.
I've also reworked and split the functions into several smaller ones and documented the control flow of the main function as much as possible (it was very difficult to understand at first what the original function was doing, so I tried my best to make it as easily understandable for future maintainers as I could).
P.S. I'm very new to alpm, so I couldn't find an alpm function that checks if a package satisfies a dependency. If one exists, we can use it instead.