Skip to content

fix(agent-core-v2): deduplicate repeated tool call ids in the loop machine requester #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sailist merged 1 commit into from
Sep 6, 2026
Merged

fix(agent-core-v2): deduplicate repeated tool call ids in the loop machine requester #3582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/agent-core-v2/src/agent/loop/machine/requester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type {
AgentLLMRequestSource,
IAgentLLMRequesterService,
} from '#/agent/llmRequester/llmRequester';
import { ToolCallIdResponseNormalizer } from '#/agent/llmRequester/toolCallIdNormalizer';
import { unwrapErrorCause } from '#/errors';
import { llmMessageFromError } from '#/llm-adapter/contract/errors';
import type { LLMRequestTrace } from '#/llm-adapter/contract/request-trace';
Expand Down Expand Up @@ -80,9 +81,17 @@ export function createMachineRequester(
baseSource?.type === 'turn' && decision.step !== undefined
? { ...baseSource, step: decision.step }
: baseSource;
const toolCallIds = new ToolCallIdResponseNormalizer(new Set());
const task = service.start(
{ source },
(part) => control.onEvent?.({ type: 'llm.delta', part }),
(part) => {
if (part.type !== 'function') {
control.onEvent?.({ type: 'llm.delta', part });
return;
}
const id = toolCallIds.remapStreamedId(part.id, part._streamIndex);
control.onEvent?.({ type: 'llm.delta', part: id === part.id ? part : { ...part, id } });
},
signal,
);
options?.onTrace?.(task.trace);
Expand Down
Loading