Skip to content

feat(agent-core-v2): drop the dangerous command guard in auto permission mode #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sailist merged 2 commits into from
Sep 4, 2026
Merged

feat(agent-core-v2): drop the dangerous command guard in auto permission mode #3529

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67270a2
feat(agent-core-v2): allow unanalyzable bash commands in auto permiss…
sailist Sep 4, 2026
c52de99
feat(agent-core-v2): drop the dangerous command guard in auto permiss…
sailist Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/auto-unanalyzable-command-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@moonshot-ai/kimi-code": patch
---

Stop blocking Bash commands that cannot be statically analyzed in auto permission mode.
9 changes: 1 addition & 8 deletions packages/agent-core-v2/src/agent/permissionPolicy/policies/dangerous-command-ask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,7 @@ export class DangerousCommandAskPermissionPolicyService implements PermissionPol
}
return { kind: 'ask', reason: { dangerous_command: verdict.command } };
}
if (auto) {
return {
kind: 'deny',
reason: { unanalyzable_command: true },
message:
'This Bash command could not be analyzed and is blocked in auto permission mode. Rewrite it with a literal command name and arguments, or ask the user to run it themselves.',
};
}
if (auto) return undefined;

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Continue scanning after an unanalyzable command

In auto mode, a command list such as $CMD --force; shutdown is now approved: analyzeSource returns immediately on the first command's unanalyzable verdict, this line abstains, and the next policy (auto-mode-approve) approves the entire Bash invocation without inspecting the known-dangerous shutdown. Preserve the unanalyzable verdict while scanning the remaining commands and prioritize any dangerous verdict before allowing the policy chain to continue.

Useful? React with 👍 / 👎.

return { kind: 'ask', reason: { unanalyzable_command: true } };
}
}
Expand Down
6 changes: 3 additions & 3 deletions packages/agent-core-v2/test/agent/permissionPolicy/permissionPolicyService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,16 +370,16 @@ describe('AgentPermissionPolicyService chain', () => {
});

it.each(['$CMD --force', 'bash -c "echo $HOME"', 'env $FLAGS'])(
'denies unanalyzable command `%s` in auto mode',
'approves unanalyzable command `%s` in auto mode',
async (command) => {
mode = 'auto';

await expect(evaluate({
toolName: 'Bash',
args: { command, timeout: 60 },
})).resolves.toMatchObject({
policyName: 'dangerous-command-ask',
result: { kind: 'deny', reason: { unanalyzable_command: true } },
policyName: 'auto-mode-approve',
result: { kind: 'approve' },
});
},
);
Expand Down
Loading