-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(kimi-code): show step retry progress in the activity indicator #2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1b941ff
feat(kimi-code): show step retry progress in the activity indicator
liruifengv 109a2f9
fix(kimi-code): show the retry indicator for mid-stream failures
liruifengv 79830f9
fix(kimi-code): drop the stale retry countdown once the attempt starts
liruifengv 257c988
fix(kimi-code): advance the retry phase on a timer instead of step st…
liruifengv ba61ccd
fix(kimi-code): cancel the retry phase timer on TUI shutdown
liruifengv 964f89d
fix(kimi-code): align the retry detail line with the spinner label
liruifengv 5fd019c
fix(kimi-code): capitalize the retry spinner label
liruifengv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Show retry progress in the loading indicator when a model request fails and is retried, with the attempt count and a detail line for the provider error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { RETRY_DETAIL_MAX_CHARS } from '../constant/rendering'; | ||
| import type { StepRetryState } from '../types'; | ||
|
|
||
| export function formatStepRetryLabel(retry: StepRetryState): string { | ||
| const base = `Retrying (${retry.nextAttempt}/${retry.maxAttempts}) · ${retry.errorName}`; | ||
| if (retry.phase === 'attempt') return base; | ||
| const delaySeconds = Math.max(1, Math.ceil(retry.delayMs / 1000)); | ||
| return `${base} · in ${delaySeconds}s`; | ||
| } | ||
|
|
||
| /** Detail line under the spinner: status code + provider message, single-line, capped. */ | ||
| export function formatStepRetryDetail(retry: StepRetryState): string { | ||
| const message = retry.errorMessage.replaceAll(/\s+/g, ' ').trim(); | ||
| const code = retry.statusCode === undefined ? '' : String(retry.statusCode); | ||
| const detail = [code, message].filter((part) => part.length > 0).join(' · '); | ||
| return detail.length > RETRY_DETAIL_MAX_CHARS | ||
| ? `${detail.slice(0, RETRY_DETAIL_MAX_CHARS - 1)}…` | ||
| : detail; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.