refactor(agent-core-v2): unify model-facing reminder scheduling

packages/agent-core-v2/AGENTS.md

@@ -86,6 +86,10 @@ Business code must not `import 'node:fs'`, write SQL, hand-roll append-logs / at
 
 `context.undo` is the only persisted undo fact. `contextMemory/conversationTime.ts` owns the conversation clock (`isUndoAnchor` — the single tick predicate used by `computeUndoCut`, the checkpoint reducers, and the transcript reducer) and the checkpoint protocol. A wire Model whose state must follow conversation undo (todo, plan, task-notification delivery, …) **MUST** be defined with `defineCheckpointedModel` — never hand-roll the push/clear/restore reducers — which also registers it into `CHECKPOINTED_MODELS` for the undo pipeline's pre-cut depth check. World-time state (turn counters, task registries, revision counters) must stay outside checkpointed Models.
 
+## Model-facing reminders
+
+Two delivery paths only — never introduce a third (no deferred-delivery queues, no mid-step splice channels): reminders that restate current state (goal state, plan mode, date change, …) register a `contextInjector` provider (`register`) that reconciles at every step head (before the step's request is built) and re-emits after compaction or undo; reminders that report a one-off event (goal cancelled, AGENTS.md discovered, `/init` finished, …) append at the event point through `IAgentSystemReminderService.appendSystemReminder` with origin `{ kind: 'injection', variant: '<domain_fact>' }`, where the event point must itself be a safe position (a step/restore hook, an idle moment, or the loop-event fold's deferred append). `kind: 'injection'` is a lifecycle classification (hidden from the UI, not an undo anchor, dropped by compaction), not a provenance claim; prompt-owned attachments additionally carry `ownerPromptId` so undo treats them as part of their host prompt.
+
 ## Docs
 
 Per-domain references live in `docs/`.

packages/agent-core-v2/docs/state-manifest.d.ts

@@ -23,7 +23,7 @@
 // references become '(circular)', and class instances collapse to a '(ClassName)'
 // marker — the wire shape of an entry is the JSON projection of the type here.
 //
-// Index (App: 0 keys · Workspace: 6 keys · Session: 18 keys · Agent: 70 keys)
+// Index (App: 0 keys · Workspace: 6 keys · Session: 18 keys · Agent: 69 keys)
 //   App
 //   Workspace
 //     workspaceDirs.ephemeralDirs          src/workspace/workspaceDirs/workspaceDirsService.ts
@@ -57,10 +57,10 @@
 //     activityView.lastTurn                           src/agent/activityView/activityViewService.ts
 //     activityView.lifecycle                          src/agent/activityView/activityViewService.ts
 //     activityView.turn                               src/agent/activityView/activityViewService.ts
+//     agentPlugin.sessionStartRefreshPending          src/agent/plugin/agentPluginService.ts
 //     agentsMdReminder.cwd                            src/agent/agentsMdReminder/agentsMdReminderService.ts
 //     agentsMdReminder.known                          src/agent/agentsMdReminder/agentsMdReminderService.ts
 //     agentsMdReminder.seeded                         src/agent/agentsMdReminder/agentsMdReminderService.ts
-//     contextInjector.isNewTurn                       src/agent/contextInjector/contextInjectorService.ts
 //     contextProjector.lastRepairSignature            src/agent/contextProjector/contextProjectorService.ts
 //     dateChange.seed                                 src/agent/dateChange/dateChangeService.ts
 //     externalHooks.stopHookContinuationUsed          src/agent/externalHooks/externalHooksService.ts
@@ -118,7 +118,6 @@
 //     toolDedupe.syntheticCallIds                     src/agent/toolDedupe/toolDedupeService.ts
 //     toolExecutor.dupTypeTurnId                      src/agent/toolExecutor/toolExecutorService.ts
 //     toolExecutor.toolCallDupTypes                   src/agent/toolExecutor/toolExecutorService.ts
-//     toolSelect.needsBoundaryInjection               src/agent/toolSelect/toolSelectAnnouncementsService.ts
 //     toolSelect.pendingLoaded                        src/agent/toolSelect/toolSelectService.ts
 //     usage.currentTurn                               src/agent/usage/usageService.ts
 //     usage.currentTurnId                             src/agent/usage/usageService.ts
@@ -752,12 +751,7 @@ export interface AgentStateSnapshot {
         readonly kind: 'injection';
         readonly variant: string;
         readonly ownerPromptId?: string;
-        readonly disclosure?: /* ContextInjectionDisclosure — packages/agent-core-v2/src/agent/contextMemory/types.ts */ {
-          readonly kind: 'date';
-          readonly renderGeneration: number;
-          readonly localDate: string;
-          readonly timeZone: string;
-        };
+        readonly disclosure?: unknown;
       } | /* ShellCommandOrigin — packages/agent-core-v2/src/agent/contextMemory/types.ts */ {
         readonly kind: 'shell_command';
         readonly phase: 'input' | 'output';
@@ -882,12 +876,7 @@ export interface AgentStateSnapshot {
       readonly kind: 'injection';
       readonly variant: string;
       readonly ownerPromptId?: string;
-      readonly disclosure?: /* ContextInjectionDisclosure — packages/agent-core-v2/src/agent/contextMemory/types.ts */ {
-        readonly kind: 'date';
-        readonly renderGeneration: number;
-        readonly localDate: string;
-        readonly timeZone: string;
-      };
+      readonly disclosure?: unknown;
     } | /* ShellCommandOrigin — packages/agent-core-v2/src/agent/contextMemory/types.ts */ {
       readonly kind: 'shell_command';
       readonly phase: 'input' | 'output';
@@ -944,12 +933,7 @@ export interface AgentStateSnapshot {
         readonly kind: 'injection';
         readonly variant: string;
         readonly ownerPromptId?: string;
-        readonly disclosure?: /* ContextInjectionDisclosure — packages/agent-core-v2/src/agent/contextMemory/types.ts */ {
-          readonly kind: 'date';
-          readonly renderGeneration: number;
-          readonly localDate: string;
-          readonly timeZone: string;
-        };
+        readonly disclosure?: unknown;
       } | /* ShellCommandOrigin — packages/agent-core-v2/src/agent/contextMemory/types.ts */ {
         readonly kind: 'shell_command';
         readonly phase: 'input' | 'output';
@@ -1012,8 +996,6 @@ export interface AgentStateSnapshot {
   'agentsMdReminder.cwd': string | undefined;
   'agentsMdReminder.known': Set<string>;
   'agentsMdReminder.seeded': boolean;
-  // src/agent/contextInjector/contextInjectorService.ts
-  'contextInjector.isNewTurn': boolean;
   // src/agent/contextProjector/contextProjectorService.ts
   'contextProjector.lastRepairSignature': string | null;
   // src/agent/dateChange/dateChangeService.ts
@@ -1125,6 +1107,8 @@ export interface AgentStateSnapshot {
   }>;
   // src/agent/permissionMode/injection/permissionModeInjection.ts
   'permissionMode.lastMode': 'manual' | 'yolo' | 'auto' | undefined;
+  // src/agent/plugin/agentPluginService.ts
+  'agentPlugin.sessionStartRefreshPending': boolean;
   // src/agent/profile/profileService.ts
   'profile.activeToolNamesOverlay': readonly string[] | undefined;
   'profile.agentsMdWarning': string | undefined;
@@ -1197,8 +1181,6 @@ export interface AgentStateSnapshot {
   // src/agent/toolExecutor/toolExecutorService.ts
   'toolExecutor.dupTypeTurnId': number | undefined;
   'toolExecutor.toolCallDupTypes': Map<string, /* ToolCallDupType — packages/agent-core-v2/src/agent/toolExecutor/toolExecutor.ts */ 'same_step' | 'cross_step'>;
-  // src/agent/toolSelect/toolSelectAnnouncementsService.ts
-  'toolSelect.needsBoundaryInjection': boolean;
   // src/agent/toolSelect/toolSelectService.ts
   'toolSelect.pendingLoaded': Set<string>;
   // src/agent/usage/usageService.ts

packages/agent-core-v2/docs/wire-manifest.d.ts

@@ -21,55 +21,56 @@
 // owning model offloads inline media to blob storage), cross-reducers
 // (foreign models that also reduce this record on dispatch and replay).
 
-// Index (48 record types)
-//   config.update                      profile               persisted  src/agent/profile/profileOps.ts
-//   context.append_loop_event          contextMemory         persisted  src/agent/contextMemory/contextOps.ts
-//   context.append_message             contextMemory         persisted  src/agent/contextMemory/contextOps.ts
-//   context.apply_compaction           contextMemory         persisted  src/agent/contextMemory/contextOps.ts
-//   context.clear                      contextMemory         persisted  src/agent/contextMemory/contextOps.ts
-//   context.undo                       contextMemory         persisted  src/agent/contextMemory/contextOps.ts
-//   cron.add                           cron                  transient  src/session/cron/cronOps.ts
-//   cron.cursor                        cron                  transient  src/session/cron/cronOps.ts
-//   cron.delete                        cron                  transient  src/session/cron/cronOps.ts
-//   forked                             goal                  persisted  src/agent/goal/goalOps.ts
-//   full_compaction.begin              fullCompaction        persisted  src/agent/fullCompaction/compactionOps.ts
-//   full_compaction.cancel             fullCompaction        persisted  src/agent/fullCompaction/compactionOps.ts
-//   full_compaction.complete           fullCompaction        persisted  src/agent/fullCompaction/compactionOps.ts
-//   goal.clear                         goal                  persisted  src/agent/goal/goalOps.ts
-//   goal.create                        goal                  persisted  src/agent/goal/goalOps.ts
-//   goal.update                        goal                  persisted  src/agent/goal/goalOps.ts
-//   interaction.request                interaction           persisted  src/session/interaction/interactionOps.ts
-//   interaction.resolved               interaction           persisted  src/session/interaction/interactionOps.ts
-//   interruptionReminder.recorded      interruptionReminder  persisted  src/agent/interruptionReminder/interruptionReminderOps.ts
-//   llm.request                        llm.requestTrace      persisted  src/agent/llmRequester/llmRequestOps.ts
-//   llm.tools_snapshot                 llm.requestTrace      persisted  src/agent/llmRequester/llmRequestOps.ts
-//   mcp.tools_discovered               mcp.discovery         persisted  src/agent/mcp/mcpDiscoveryOps.ts
-//   permission.record_approval_result  permissionRules       persisted  src/agent/permissionRules/permissionRulesOps.ts
-//   permission.rules.add               permissionRules       transient  src/agent/permissionRules/permissionRulesOps.ts
-//   permission.set_mode                permissionMode        persisted  src/agent/permissionMode/permissionModeOps.ts
-//   plan_mode.cancel                   plan                  persisted  src/features/plan/planOps.ts
-//   plan_mode.enter                    plan                  persisted  src/features/plan/planOps.ts
-//   plan_mode.exit                     plan                  persisted  src/features/plan/planOps.ts
-//   plan.revision                      plan                  persisted  src/features/plan/planOps.ts
-//   profile.bind                       profile               persisted  src/agent/profile/profileOps.ts
-//   skill.activate                     skill                 transient  src/agent/skill/skillOps.ts
-//   swarm_mode.enter                   swarm                 persisted  src/agent/swarm/swarmOps.ts
-//   swarm_mode.exit                    swarm                 persisted  src/agent/swarm/swarmOps.ts
-//   task.started                       task                  persisted  src/agent/task/taskOps.ts
-//   task.terminated                    task                  persisted  src/agent/task/taskOps.ts
-//   token_counting.measured            tokenCounting         transient  src/agent/tokenCounting/tokenCountingOps.ts
-//   token_counting.rebased             tokenCounting         transient  src/agent/tokenCounting/tokenCountingOps.ts
-//   token_counting.truncated           tokenCounting         transient  src/agent/tokenCounting/tokenCountingOps.ts
-//   tools.register_user_tool           userTool              persisted  src/agent/userTool/userToolOps.ts
-//   tools.reset_active_tools           profile.activeTools   persisted  src/agent/profile/profileOps.ts
-//   tools.set_active_tools             profile.activeTools   persisted  src/agent/profile/profileOps.ts
-//   tools.unregister_user_tool         userTool              persisted  src/agent/userTool/userToolOps.ts
-//   tools.update_store                 todo                  persisted  src/session/todo/todoOps.ts
-//   turn.cancel                        turn                  persisted  src/agent/loop/turnOps.ts
-//   turn.ended                         turn                  persisted  src/agent/loop/turnOps.ts
-//   turn.prompt                        turn                  persisted  src/agent/loop/turnOps.ts
-//   turn.steer                         turn                  persisted  src/agent/loop/turnOps.ts
-//   usage.record                       usage                 persisted  src/agent/usage/usageOps.ts
+// Index (49 record types)
+//   config.update                      profile                     persisted  src/agent/profile/profileOps.ts
+//   context.append_loop_event          contextMemory               persisted  src/agent/contextMemory/contextOps.ts
+//   context.append_message             contextMemory               persisted  src/agent/contextMemory/contextOps.ts
+//   context.apply_compaction           contextMemory               persisted  src/agent/contextMemory/contextOps.ts
+//   context.clear                      contextMemory               persisted  src/agent/contextMemory/contextOps.ts
+//   context.undo                       contextMemory               persisted  src/agent/contextMemory/contextOps.ts
+//   cron.add                           cron                        transient  src/session/cron/cronOps.ts
+//   cron.cursor                        cron                        transient  src/session/cron/cronOps.ts
+//   cron.delete                        cron                        transient  src/session/cron/cronOps.ts
+//   forked                             goal                        persisted  src/agent/goal/goalOps.ts
+//   full_compaction.begin              fullCompaction              persisted  src/agent/fullCompaction/compactionOps.ts
+//   full_compaction.cancel             fullCompaction              persisted  src/agent/fullCompaction/compactionOps.ts
+//   full_compaction.complete           fullCompaction              persisted  src/agent/fullCompaction/compactionOps.ts
+//   goal.clear                         goal                        persisted  src/agent/goal/goalOps.ts
+//   goal.create                        goal                        persisted  src/agent/goal/goalOps.ts
+//   goal.update                        goal                        persisted  src/agent/goal/goalOps.ts
+//   interaction.request                interaction                 persisted  src/session/interaction/interactionOps.ts
+//   interaction.resolved               interaction                 persisted  src/session/interaction/interactionOps.ts
+//   interruptionReminder.recorded      interruptionReminder        persisted  src/agent/interruptionReminder/interruptionReminderOps.ts
+//   llm.request                        llm.requestTrace            persisted  src/agent/llmRequester/llmRequestOps.ts
+//   llm.tools_snapshot                 llm.requestTrace            persisted  src/agent/llmRequester/llmRequestOps.ts
+//   mcp.tools_discovered               mcp.discovery               persisted  src/agent/mcp/mcpDiscoveryOps.ts
+//   permission.record_approval_result  permissionRules             persisted  src/agent/permissionRules/permissionRulesOps.ts
+//   permission.rules.add               permissionRules             transient  src/agent/permissionRules/permissionRulesOps.ts
+//   permission.set_mode                permissionMode              persisted  src/agent/permissionMode/permissionModeOps.ts
+//   plan_mode.cancel                   plan                        persisted  src/features/plan/planOps.ts
+//   plan_mode.enter                    plan                        persisted  src/features/plan/planOps.ts
+//   plan_mode.exit                     plan                        persisted  src/features/plan/planOps.ts
+//   plan.revision                      plan                        persisted  src/features/plan/planOps.ts
+//   plugin.session_start               pluginSessionStartSnapshot  persisted  src/agent/plugin/agentPluginOps.ts
+//   profile.bind                       profile                     persisted  src/agent/profile/profileOps.ts
+//   skill.activate                     skill                       transient  src/agent/skill/skillOps.ts
+//   swarm_mode.enter                   swarm                       persisted  src/agent/swarm/swarmOps.ts
+//   swarm_mode.exit                    swarm                       persisted  src/agent/swarm/swarmOps.ts
+//   task.started                       task                        persisted  src/agent/task/taskOps.ts
+//   task.terminated                    task                        persisted  src/agent/task/taskOps.ts
+//   token_counting.measured            tokenCounting               transient  src/agent/tokenCounting/tokenCountingOps.ts
+//   token_counting.rebased             tokenCounting               transient  src/agent/tokenCounting/tokenCountingOps.ts
+//   token_counting.truncated           tokenCounting               transient  src/agent/tokenCounting/tokenCountingOps.ts
+//   tools.register_user_tool           userTool                    persisted  src/agent/userTool/userToolOps.ts
+//   tools.reset_active_tools           profile.activeTools         persisted  src/agent/profile/profileOps.ts
+//   tools.set_active_tools             profile.activeTools         persisted  src/agent/profile/profileOps.ts
+//   tools.unregister_user_tool         userTool                    persisted  src/agent/userTool/userToolOps.ts
+//   tools.update_store                 todo                        persisted  src/session/todo/todoOps.ts
+//   turn.cancel                        turn                        persisted  src/agent/loop/turnOps.ts
+//   turn.ended                         turn                        persisted  src/agent/loop/turnOps.ts
+//   turn.prompt                        turn                        persisted  src/agent/loop/turnOps.ts
+//   turn.steer                         turn                        persisted  src/agent/loop/turnOps.ts
+//   usage.record                       usage                       persisted  src/agent/usage/usageOps.ts
 
 /**
  * model: profile · persisted
@@ -448,6 +449,15 @@ interface PlanRevisionPayload {
   bytes: number;
 }
 
+/**
+ * model: pluginSessionStartSnapshot · persisted
+ * owner: src/agent/plugin/agentPluginOps.ts
+ */
+interface PluginSessionStartPayload {
+  _name: 'plugin.session_start';
+  content: string | null;
+}
+
 /**
  * model: profile · persisted · cross-reducers: profile.activeTools
  * owner: src/agent/profile/profileOps.ts
@@ -610,7 +620,7 @@ interface ToolsUpdateStorePayload {
 }
 
 /**
- * model: turn · persisted · cross-reducers: interruptionReminder
+ * model: turn · persisted
  * owner: src/agent/loop/turnOps.ts
  */
 interface TurnCancelPayload {
@@ -746,6 +756,7 @@ interface WirePayloadMap {
   "plan_mode.enter": PlanModeEnterPayload;
   "plan_mode.exit": PlanModeExitPayload;
   "plan.revision": PlanRevisionPayload;
+  "plugin.session_start": PluginSessionStartPayload;
   "profile.bind": ProfileBindPayload;
   "skill.activate": SkillActivatePayload;
   "swarm_mode.enter": SwarmModeEnterPayload;