Repository navigation
feat: send prompt-attached videos directly with the prompt #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
128faf1
feat: send prompt-attached videos directly with the prompt
RealKai42 6946c57
fix: fall back to inline video when the upload channel fails
RealKai42 ead47c6
test: cover prompt video edge cases and failure paths
RealKai42 8881ef3
Merge remote-tracking branch 'origin/main' into feat/prompt-video-inline
RealKai42 64d95ef
fix: surface auth rejections from the video upload channel
RealKai42 3a4e720
fix: keep the by-design no-hook video error from degrading to inline
RealKai42 465e7a6
fix: constrain the llm video route param to a safe alphabet
RealKai42 172a531
style(agent-core-v2): move added explanations into top-of-file commen…
RealKai42 3e08864
fix: reject prompt video uploads when the model lacks video input
RealKai42 99cfdab
fix: sniff uploaded video bytes before inlining them
RealKai42 0f89d7e
test: keep the generation stub pending until the abort lands
RealKai42 b1c6e03
fix: validate prompt file references before mutating session controls
RealKai42 a9d0ff8
fix: serialize prompt submissions per session
RealKai42 ef197c2
fix: play reloaded provider videos through the authenticated fetch path
RealKai42 ece87aa
fix: fence pending video submits against session and model switches
RealKai42 b8077ec
fix: preserve the caller's video path verbatim in uploadVideo
RealKai42 259e4e6
fix: forward provider-issued ids on image URL prompt parts too
RealKai42 6f0c9ec
fix(web): reconcile inlined video echoes into the optimistic user mes…
RealKai42 f536783
fix: queue bash submits behind a pending video upload
RealKai42 a637ea5
test: cast the driver through unknown for the session-switch fence test
RealKai42 d922a4c
fix: validate prompt file references before resolving the prompt agent
RealKai42 defe33d
fix: key the playback mapping by the id embedded in the reference URL
RealKai42 c5f1a71
fix: sanitize provider video ids on the write side of the playback map
RealKai42 61db503
fix(web): keep recovered provider videos resendable through the edit …
RealKai42 8bb4bca
fix: fall back to inline video for no-hook providers whose wire carri…
RealKai42 4f7d3cd
test: satisfy the full IBlobStore shape in the playback-map stub
RealKai42 c5c370d
fix: queue prompt-producing slash commands behind pending uploads
RealKai42 5cb32bc
fix: validate media kinds in the prompt file-reference preflight
RealKai42 78061b9
fix(web): play sent and recovered videos in the file preview
RealKai42 a780bce
fix(web): preview recovered videos with the authenticated blob URL
RealKai42 399ae2e
style(agent-core-v2): move the inline-fallback note into the module h…
RealKai42 0df5e3b
fix: fence delayed bash submits to the originating session
RealKai42 e76851f
fix: emit prompt video telemetry from the agent scope
RealKai42 9a9f9d2
fix: preserve provider image ids through legacy projections and web m…
RealKai42 a08db8a
fix(web): revoke recovered video blob URLs before dropping attachments
RealKai42 37eacff
fix: serialize foreground slash commands behind pending uploads
RealKai42 45c3f81
fix: defer session controls until media preparation succeeds
RealKai42 d6f64ef
chore: bump the new SDK video upload API as a minor release
RealKai42 0998978
fix: re-check busy state before draining upload-queued commands
RealKai42 78f5ca9
fix: resolve profile-bound models before choosing the uploader
RealKai42 6a1bd26
refactor: resolve prompt videos at request time inside the engine
RealKai42 1c50a40
fix: propagate abort through video upload delivery instead of degrading
RealKai42 a32e0b6
fix: keep the tag form for no-upload providers whose wire drops inlin…
RealKai42 353210a
fix: escape the NUL separator in the video upload cache key
RealKai42 febd214
fix: check the abort signal before the inline video fallback
RealKai42 57af423
fix: retry transient prompt video upload failures on later steps
RealKai42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Fix ReadMediaFile failing on videos when the model's provider has no usable file upload channel — the video now falls back to being sent inline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": minor | ||
| --- | ||
|
|
||
| Send pasted videos to the model directly with the prompt instead of routing them through a ReadMediaFile tool call, so video input is faster and no longer depends on an extra tool round trip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code-sdk": patch | ||
| --- | ||
|
|
||
| Add Session.uploadVideo to upload a local video through the session's current model and embed the returned reference as a prompt part. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| web: Keep uploaded videos playable in the chat after reloading or resuming a session. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.