fix(soul): carry approval cancellation feedback to ApprovalResult

[wbxl2000]

Related Issue

Related to #1823 — addresses only the UX/display aspect described in the issue (the Rejected by user misleading message on timeout). Does not resolve #1823; the broader configurable timeout feature request is already being tracked by #1837.

Description

Bug

When the 300 s safety timeout in ApprovalRuntime.wait_for_response fires (e.g. the user stepped away from their SSH/tmux session), _cancel_request writes request.feedback = "approval timed out" to the record before raising ApprovalCancelledError:

# src/kimi_cli/approval_runtime/runtime.py
self._cancel_request(request_id, feedback="approval timed out")
raise ApprovalCancelledError(request_id) from None

But the outer Approval.request was dropping that feedback:

# Before
except ApprovalCancelledError:
    return ApprovalResult(approved=False)

With empty feedback, ApprovalResult.rejection_error() fell back to ToolRejectedError()'s default Rejected by user brief — so users returning to their terminal saw a message implying they had manually rejected the tool call, when they had just walked away.

Fix

Read the feedback back from the record via the existing public get_request API:

except ApprovalCancelledError:
    record = self._runtime.get_request(request_id)
    return ApprovalResult(approved=False, feedback=record.feedback if record else "")

After the fix, the rejection surface reads:

• Brief: Rejected: approval timed out
• Message: The tool call is rejected by the user. User feedback: approval timed out

The if record else "" fallback preserves pre-fix behavior for the theoretical record is None case, and the read-from-record approach keeps all cancel paths uniform without inflating ApprovalCancelledError with state.

Tests

• Extended test_approval_runtime_wait_for_response_times_out to assert record.feedback == "approval timed out" after timeout (guards the upstream invariant the fix depends on).
• New regression test test_approval_request_timeout_carries_feedback_to_result exercising Approval.request through the cancellation path; asserts both ApprovalResult.feedback round-trips and rejection_error().brief == "Rejected: approval timed out". Verified locally that reverting the fix makes this test fail with AssertionError: assert '' == 'approval timed out'.

Checklist

• I have read the CONTRIBUTING document.
• I have linked the related issue (NOT ACTUALLY CLOSED: Feature Request: Configurable Approval Request Timeout (or Unlimited) #1823, related not resolved).
• I have added tests that prove my fix is effective.
• I have updated the changelog (root CHANGELOG.md + en/zh release-notes mirrors).
• No user-facing docs changes needed (pure behavior fix; no new config, flag, or UI surface).

---

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

[wbxl2000]

BEFORE

AFTER