[Fix]: Clear mods by code data before (re)loading to prevent duplicate key errors #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadAsync
clears theModViewModels
andMods
collections, but notmodsByCode
which is also filled in this method.In practice,
LoadAsync
currently only runs once when theEngineView
is loaded, so the duplicate key errors don't actually occur in normal usage. However, if you're already clearingModViewModels
andMods
to prevent similar issues when it's called multiple times, you should clearmodsByCode
as well. Doing so could still be useful if you for example want to benchmark the method.