Fixup support of -o for OutputFolder #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer require Templates to be installed in the Skyrim\Data folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer require Templates to be installed in the Skyrim\Data folder
So, I tried to use this and was partly confused. LOOT said I needed to include it deployed (ala Nemesis), the instructions on the readme here said to install it outside of Skyrim\Data, but set the working folder to \Data and then use -o to set an Output path.
I found multiple cases where everything was read from the current directory, or written to the current directory mismatching what the -o setting was implying. I fixed several cases where the output folder wasn't set.
I've never been a fan of extra files deployed, so I configured the templates to load from the .exe folder as well as the current folder gathering both the deployed and non-deployed templates. The base ordering was also updated to sort by name as a last resort.
If i infered anything terribly wrong, I'll be happy to fix it. I try not to force my personal flavor of coding on others, but you had a mix of tabs and spaces, so, i just didn't change anything i didn't already have to change. :)
Hope this changeset helps. Thanks for the project. Looking good!