hotfix(adapter): default MOLECULE_A2A_PLATFORM_ENABLED=false - #35
Merged
Merged
Conversation
Staging E2E for PR #32 surfaced a workspace boot failure: the deployed image's hermes gateway never bound :8645, so adapter.setup()'s /a2a/health probe got httpx.ConnectError and the workspace went status=failed at ~498s. Root cause is image-side install/discovery of the molecule-a2a plugin, NOT the executor wire shape. Local scripts/e2e_full_chain.py runs against a venv where I'd already installed the plugin manually — it didn't catch the deployment-shape divergence. Flip the default off to restore the legacy /v1/chat/completions fallback (no session continuity, but works). Plugin path stays opt-in via MOLECULE_A2A_PLATFORM_ENABLED=true so debugging can continue per-workspace without rolling the whole image again. Re-enabling will require: - An image-build smoke test that verifies pip show hermes-platform-molecule-a2a + hermes config show inside the built container (filed separately) - Verifying the molecule-a2a config stanza actually lands in ~/.hermes/config.yaml inside the running container Tests updated: 37 pass. Plugin-path tests now opt-in via the helper's default; default-detection test asserts the new chat_completions fallback. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Staging E2E for PR #32 surfaced a workspace boot failure on the rebuilt image:
adapter.setup()probeshttp://127.0.0.1:8645/a2a/health(the molecule-a2a plugin endpoint):8645inside the container —httpx.ConnectError: All connection attempts failedfailedafter ~498s of cloud-initRoot cause is image-side plugin install/discovery, not the executor wire shape. My local
scripts/e2e_full_chain.pyruns against a venv where I'd manually installed the plugin — it didn't catch the deployment-shape divergence (instance of thefeedback_real_subprocess_test_for_boot_pathrule one layer deeper than tested).What this PR does
Flips
MOLECULE_A2A_PLATFORM_ENABLEDdefault fromtrue→false. Falls back to/v1/chat/completionstransport (no session continuity, but works). Plugin path is now opt-in via env var so debugging can continue per-workspace.What re-enabling will need (filed separately)
pip show hermes-platform-molecule-a2a+hermes config showsucceed inside the built container.platforms.molecule-a2astanza actually lands in~/.hermes/config.yamlinside the running container (start.sh seed path may not fire correctly).Test plan
_make_executorhelper's default.test_executor_init_defaults_to_chat_completionsasserts new prod default.onlineinstead offailed.🤖 Generated with Claude Code