security(incident-log): redact full token values from F1088 incident report - #97
Closed
HongmingWang-Rabbit wants to merge 1 commit into
Closed
security(incident-log): redact full token values from F1088 incident report#97HongmingWang-Rabbit wants to merge 1 commit into
HongmingWang-Rabbit wants to merge 1 commit into
Conversation
…report The INCIDENT_LOG.md F1088 entry documented three production credentials that leaked via molecule-core PR #1098 (commit d513a0c) and were then INCLUDED IN PLAINTEXT in the documentation itself — the incident report became a secondary leak surface. Status of the three tokens (per the report's own Blast Radius table): - MiniMax (sk-cp-...KVw): revoked / endpoint inactive - GitHub PAT (github_pat_...hsIJLIL): revoked, confirmed 401 - Admin token (HlgeMb8...ShARE=): treated as active, rotation pending Even revoked tokens add noise to security audits and are findable via GitHub Code Search on the public docs repo. This PR replaces the full values with the short-suffix convention already in use in the same file's Blast Radius table, preserving the audit trail without the public-search surface. Side note: caught by EnterOS-AI/enter-os-core#2109's secret-scan workflow on PR #96 (the org-wide rollout that reused this same regex set caught its own first real find before the rollout PR even merged). The full values remain in molecule-core git history per F1088's explicit closure decision (no BFG scrub required); this PR doesn't change that. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
[Molecule-Platform-Evolvement-Manager] Superseded by #96 — the scrub commit was merged into the workflow-enrollment branch so the secret-scan check sees both the workflow file AND the scrubbed INCIDENT_LOG in one diff. Avoids the catch-22 where #97 had no scan to validate it (branched before #96 added the workflow) and #96 couldn't pass scan until the F1088 tokens were scrubbed. File changes preserved at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Molecule-Platform-Evolvement-Manager]
Background
EnterOS-AI/enter-os-core#2109 shipped an org-wide secret-scan workflow. The first repo it caught a real match in was THIS one —
content/docs/incidents/INCIDENT_LOG.md.The F1088 incident report documented three production credentials that leaked via molecule-core PR #1098 (commit d513a0c), and then INCLUDED THEM IN PLAINTEXT IN THE DOCUMENTATION ITSELF. The incident report became a secondary leak surface — and the docs repo is publicly indexed.
Token status (per the report's own Blast Radius table)
sk-cp-...KVwgithub_pat_...hsIJLILHlgeMb8...ShARE=Two of three are confirmed revoked. The third (admin token) is still pending rotation per the report itself.
What this PR does
What this PR does NOT change
molecule-coregit history per F1088's explicit closure decision (no BFG scrub required, no active public forks).Asks for the user (separate from this PR)
Test plan
git grepconfirms no full token values remain in the working tree