[Matrix][routines] Add Column-Major Memory Layout Support Across All Matrix Routines #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and indexing operations.
…l for different layout combinations
forfudan
approved these changes
Apr 21, 2025
MadAlex1997
approved these changes
Apr 21, 2025
MadAlex1997
merged commit fa83d40
into
Mojo-Numerics-and-Algorithms-group:pre-0.7
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances Matrix with support for both C-contiguous (row-major) and F-contiguous (column-major) memory layouts across all matrix routines. Default memory layout remains C-contiguous to keep API close to NumPy. Matrix tests are performed for both memory layouts.
F_CONTIGUOUSto control matrix memory layout in tests-D F_CONTIGUOUS