[core][complex ndarray] Remove Complex DType #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the distinction between
NDArrayandComplexNDArraywas partially encoded through the use ofDTypeandCDType. This PR simplifies the type system by removing the customCDTypedatatype and replacing it with the standardDType. The use ofCDTypeintroduced issues with Mojo's compile-time type conversions, resulting in suboptimal user ergonomics and problems when converting between datatypes. To address this, we are standardizing onDTypemoving forward.New Syntax Proposal
To clearly differentiate between functions that create or manipulate standard and complex arrays, we introduce a simple naming convention: append a
Csuffix to functions returning complex arrays since Mojo does not support function overloading based on return type. The following is one such example,This approach keeps the API intuitive, avoids return-type ambiguity, and aligns better with Mojo's type system and simplifies a lot of type conversions.