Skip to content

[core][complex ndarray] Improve ComplexNDArray getter methods #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 11, 2025
Merged

[core][complex ndarray] Improve ComplexNDArray getter methods #229

merged 5 commits into from
Mar 11, 2025

Conversation

@shivasankarka
Copy link
Collaborator

@shivasankarka shivasankarka commented Mar 10, 2025 •
edited
Loading

  • This PR aims to improve the existing ComplexNDArray getter methods by aligning with the methods currently implemented in the NDArray.
  • It's the first step towards standardizing ComplexNDArray methods to match those of NDArray to provide seamless transition between the two and to lay the foundation for the upcoming FFT module PR.

@shivasankarka shivasankarka changed the title [core][complex ndarray] Improve ComplexNDArray getter [core][complex ndarray] Improve ComplexNDArray getter method Mar 10, 2025
@shivasankarka shivasankarka changed the title [core][complex ndarray] Improve ComplexNDArray getter method [core][complex ndarray] Improve ComplexNDArray getter methods Mar 10, 2025
@shivasankarka shivasankarka requested a review from forfudan March 11, 2025 08:16
@forfudan forfudan merged commit 510a4c4 into Mojo-Numerics-and-Algorithms-group:pre-0.7 Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@forfudan forfudan forfudan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivasankarka @forfudan