[fix] Hotfix the bug that numojo crashes on mojopkg #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-Algorithms-group#224) @shivasankarka @MadAlex1997, This is to pull the commits that were directly made in `main` into `pre-0.7`. No squash is needed.
…rithms-group#226) This will: 1. Implemented `take_along_axis` function in `numojo/routines/indexing.mojo`: - Takes values from an input array along a specified axis based on indices - Handles arrays of any dimension with axis specification - Supports broadcasting of indices when shapes don't exactly match - Includes proper error handling for invalid inputs 2. Created comprehensive test suite in `tests/routines/test_indexing.mojo`: - Tests for arrays of different dimensions (1D, 2D, 3D) - Tests with various axis specifications (positive, negative indices) - Tests with different index types (int32, int64) - Verification against NumPy's implementation for correctness
MadAlex1997
approved these changes
Mar 7, 2025
MadAlex1997
merged commit f0dea37
into
Mojo-Numerics-and-Algorithms-group:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
mojoproject.tomlfile and thenumojopackage, focusing on improving the build process, testing, and formatting functionalities. Additionally, there are updates to the handling of print options in thenumojopackage.Improvements to build and testing process:
mojoproject.toml: Updated thepackagetask to include copying the package to the tests folder and modified thetesttask to test the built package.mojoproject.toml: Simplified thefinaltask to run format and test commands, and updated thefalias to run thefinaltask.Dependency updates:
mojoproject.toml: Updated themaxdependency version to25.1.1.Codebase simplification:
numojo/__init__.mojo,numojo/core/complex/complex_ndarray.mojo,numojo/routines/io/__init__.mojo: Removed the unusedprintoptionsimport. [1] [2] [3]numojo/routines/io/formatting.mojo: ReplacedGLOBAL_PRINT_OPTIONSwith a localdefault_print_optionsinstance in several functions and methods, and added new parameters to theformat_floating_scientificandformat_floating_precisionfunctions for better control over formatting behavior. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]