Skip to content

[extrema][optimize] Update max and min functions to allow any order and any axis + some optimization work #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 17, 2025
Merged

[extrema][optimize] Update max and min functions to allow any order and any axis + some optimization work #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
64157cf
Update `max`
forfudan Feb 17, 2025
9cd6958
Optimize `apply_func_on_array_with_dim_reduction`
forfudan Feb 17, 2025
b79c410
Use // % to replace divmod
forfudan Feb 17, 2025
e47b5e1
Re-write `min`
forfudan Feb 17, 2025
ae43787
Vectorize the calculation
forfudan Feb 17, 2025
7ae2193
Add corresponding methods for NDArray.
forfudan Feb 17, 2025
5312343
`num_elements()` -> `size`
forfudan Feb 17, 2025
183a002
Minor update
forfudan Feb 17, 2025
9cee3ea
Optimize axisiter
forfudan Feb 17, 2025
a959509
Add argsort in NDArray methods
forfudan Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mojoproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ test_core = "magic run mojo test tests/core -I ./ -I ./tests/"
test_creation = "magic run mojo test tests/routines/test_creation.mojo -I ./ -I ./tests/"
test_linalg = "magic run mojo test tests/routines/test_linalg.mojo -I ./ -I ./tests/"
test_manipulation = "magic run mojo test tests/routines/test_manipulation.mojo -I ./ -I ./tests/"
test_math = "magic run mojo test tests/routines/test_math.mojo -I ./ -I ./tests/"
test_random = "magic run mojo test tests/routines/test_random.mojo -I ./ -I ./tests/"
test_statistics = "magic run mojo test tests/routines/test_statistics.mojo -I ./ -I ./tests/"
test_sorting = "magic run mojo test tests/routines/test_sorting.mojo -I ./ -I ./tests/"
Expand Down
4 changes: 0 additions & 4 deletions numojo/__init__.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,7 @@ from numojo.routines.math import gradient, trapz
from numojo.routines.math import exp, exp2, expm1, log, ln, log2, log10, log1p
from numojo.routines.math import (
max,
maxT,
min,
minT,
amin,
amax,
mimimum,
maximum,
)
Expand Down
6 changes: 3 additions & 3 deletions numojo/core/_array_funcs.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ fn math_func_1_array_in_one_array_out[
var simd_data = array._buf.ptr.load[width=simd_width](i)
result_array._buf.ptr.store(i, func[dtype, simd_width](simd_data))

vectorize[closure, width](array.num_elements())
vectorize[closure, width](array.size)

return result_array

Expand Down Expand Up @@ -79,7 +79,7 @@ fn math_func_2_array_in_one_array_out[
i, func[dtype, simd_width](simd_data1, simd_data2)
)

vectorize[closure, width](result_array.num_elements())
vectorize[closure, width](result_array.size)

return result_array

Expand Down Expand Up @@ -115,5 +115,5 @@ fn math_func_one_array_one_SIMD_in_one_array_out[
i, func[dtype, simd_width](simd_data1, scalar)
)

vectorize[closure, width](result_array.num_elements())
vectorize[closure, width](result_array.size)
return result_array
Loading