Resolving feedback on @minecraft/math after testing internally #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with shortly named methods
JakeShirley
approved these changes
Jan 19, 2024
Sure, we roughly follow the naming guidelines from the google style guide: https://google.github.io/styleguide/jsguide.html#naming I also found that we can configure this naming convention to be enforced by eslint, I'll open up a user story to do so https://typescript-eslint.io/rules/naming-convention/ . Arguably, we can enforce that internally too, though i'll test out here first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a bit of usability feedback from initial integration to our behavior packs like editor. I am also adding the beginning of the release pipeline to at least get build validation in main.