Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding linting check for core-build-task #28

Merged
merged 8 commits into from
May 9, 2024
Merged

Adding linting check for core-build-task #28

merged 8 commits into from
May 9, 2024

Conversation

frgarc
Copy link
Contributor

@frgarc frgarc commented May 7, 2024

Description

  • Adding basic linting check for core-build-task.
    • Adding triple equality rule.
  • Enabling prettier check for math library.
  • Enabling ESLint check at Visual Studio Code (for flat config).

@frgarc frgarc requested review from rlandav and JakeShirley as code owners May 7, 2024 20:59
SBLMikeDemone
SBLMikeDemone approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@SBLMikeDemone SBLMikeDemone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

rlandav
rlandav approved these changes May 9, 2024
View reviewed changes
tools/core-build-tasks/package.json Outdated Show resolved Hide resolved
@rlandav
Copy link
Collaborator

rlandav commented May 9, 2024

Let me know when you want me to merge!

@rlandav rlandav merged commit 75c0d9f into main May 9, 2024
2 checks passed
@rlandav rlandav deleted the frgarc/lintCore branch May 9, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SBLMikeDemone SBLMikeDemone SBLMikeDemone approved these changes

@rlandav rlandav rlandav approved these changes

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner

@AlexDenfordSkyboxLabs AlexDenfordSkyboxLabs Awaiting requested review from AlexDenfordSkyboxLabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frgarc @rlandav @SBLMikeDemone