Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spaces in the directory path when getting the eslint config file #25

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

ThomasOrs
Copy link
Contributor

@ThomasOrs ThomasOrs commented Mar 18, 2024

Resolves #24 by wrapping configFilePath in "". Adding support for parent directories which have spaces in their name. Such as `D:\2. Repos\

@rlandav
Copy link
Collaborator

rlandav commented Mar 18, 2024

After you run the build, can you update the package.json in tools/eslint-plugin-minecraft-linting locally with a test version and then run npm pack to get a tarball to try that out in your setup. Would be good to make sure any specific use cases are addressed in a single PR so it's not spread out across PRs (let's avoid whack-a-mole 😄 )

@rlandav rlandav merged commit 5187ed5 into Mojang:main Mar 18, 2024
2 checks passed
ThomasOrs added a commit to ThomasOrs/minecraft-scripting-libraries that referenced this pull request Mar 20, 2024
…config file (Mojang#25)

* Add support for space in config path

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core Task eslintTask does not support directories with spaces in their names
2 participants