Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(val): Texture + Pack test additions #51

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

mammerla
Copy link
Collaborator

  • Add more checking for texture images and overall texture image texel limits
  • Support checking for more different types of packs

- Add more checking for texture images and overall texture image texel limits
- Support checking for more different types of packs
Copy link

@ihfdayton ihfdayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Mike

@m-brisch m-brisch requested a review from Copilot February 11, 2025 17:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 23 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • app/test/scenarios/serveCommandValidate/report.json: Language not supported
  • app/test/scenarios/simple/report.json: Language not supported
  • app/test/scenarios/validateAddons3ExtraneousStuffUsesMinecraftCommand/content3.csv: Language not supported
  • app/test/scenarios/validateAddons3ExtraneousStuffUsesMinecraftCommand/content3.mcr.json: Language not supported
  • app/test/scenarios/validateAddons3ExtraneousStuffUsesMinecraftCommand/content3.report.html: Language not supported
  • app/test/scenarios/validateAddons3PlatformVersions/content3.csv: Language not supported
  • app/test/scenarios/validateAddons3PlatformVersions/content3.mcr.json: Language not supported
  • app/test/scenarios/validateAddons3PlatformVersions/content3.report.html: Language not supported
  • app/src/app/ProjectItemUtilities.ts: Evaluated as low risk
  • app/src/minecraft/ManagedComponent.ts: Evaluated as low risk
  • app/src/minecraft/Pack.ts: Evaluated as low risk
  • README.md: Evaluated as low risk
  • app/src/app/IProjectItemData.ts: Evaluated as low risk
  • app/src/manager/MinEngineVersionManager.ts: Evaluated as low risk
  • app/src/dataform/IFormDefinition.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

app/src/app/Project.ts:1938

  • The tag name 'personapackmanifest' is inconsistent with other tags. It should be renamed to 'personaPackManifest'.
tag = "personapackmanifest";
@mammerla mammerla merged commit b4d9482 into main Feb 11, 2025
3 checks passed
@mammerla mammerla deleted the mammerla-texturespluspackmanifests branch February 11, 2025 19:38
Copy link
Contributor

🎉 This issue has been resolved in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants