Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Apache Commons Lang and unnecessary Guava usages #25

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Remove Apache Commons Lang and unnecessary Guava usages #25

wants to merge 10 commits into from

Conversation

MrMicky-FR
Copy link

@MrMicky-FR MrMicky-FR commented Oct 10, 2018 •
edited
Loading

  • Remove Apache Commons Lang (was almost not used and is not really necessary with Guava)
  • Remove unnecessary Guava usages like Lists.newArrayList() that can be replace with just new ArrayList<>()

@MrMicky-FR
Copy link
Author

Hi, any updates on this @RainWarrior ?
Thanks

@RainWarrior RainWarrior mentioned this pull request May 11, 2020
Merged
Marcono1234
Marcono1234 reviewed May 31, 2020
View reviewed changes
Copy link

@Marcono1234 Marcono1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that org.apache.commons.lang3.tuple.Triple is an abstract class and subclasses may be mutable, while the newly added Triple is immutable. However, that is probably fine since Minecraft only uses the immutable implementation?

src/main/java/com/mojang/datafixers/util/Triple.java Outdated Show resolved Hide resolved
src/main/java/com/mojang/datafixers/util/Triple.java Show resolved Hide resolved
@liach liach mentioned this pull request Apr 7, 2022
Merged
@peterix
Copy link
Contributor

peterix commented Oct 26, 2022

Closing and reopening to rerun checks.

@peterix peterix closed this Oct 26, 2022
@peterix peterix reopened this Oct 26, 2022
@MrMicky-FR
Copy link
Author

More than 4 years, that's a while! @peterix I've resolved the merge conflicts and the build/tests run locally for me, just the GitHub Actions workflow is awaiting approval from a maintainer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcono1234 Marcono1234 Marcono1234 left review comments

@hugmanrique hugmanrique hugmanrique left review comments

@kashike kashike kashike requested changes

@RainWarrior RainWarrior RainWarrior requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MrMicky-FR @peterix @RainWarrior @kashike @hugmanrique @Marcono1234