New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converter: Avoid copying incomplete triangles #137

Open

Germanunkol wants to merge 1 commit into Moguri:master from Germanunkol:master

Germanunkol commented Sep 5, 2024

When converting collision meshes, degenerate triangles (i.e. single edges) would result in an indexing error in the line

                        pos2 = vdata[vertices[i + 2]].xyz

This is because the line

                    for i in range(0, len(vertices), 3):

will enter the loop once (with i == 0) even if len(vertices) is 2. In this case, i+2 will try to read past the end of the vertices array.

This pull request catches this case and then skips the polygon with a warning.


          converter: Avoid copying incomplete triangles

361f328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet