Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how tangents and bi-tangents are treated #69

Open
Moguri opened this issue May 29, 2020 · 1 comment
Open

Document how tangents and bi-tangents are treated #69

Moguri opened this issue May 29, 2020 · 1 comment

Comments

@Moguri
Copy link
Owner

Moguri commented May 29, 2020

glTF uses a 4-component tangent vector and does not supply a bi-tangent (this is assumed to be calculated in the shader). As such, models loaded by panda3d-gltf will follow this convention. There is also talk about following this in Panda as well. However, at the moment, this means that models loaded by this project will not work correctly with the normal mapping done by the auto-shader (simplepbr does support these tangents).

@rdb
Copy link
Collaborator

rdb commented Dec 23, 2020

A further note is that the shader generator is currently unable to process the tangents that panda3d-gltf uses, because it specifically looks for a tangent.0 column (with 0 being the name of the texture coordinate set that panda3d-gltf generates), as opposed to a generic tangent column. I am not yet sure whether this is something that should be changed in simplepbr, panda3d-gltf, or panda3d itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants