This repository has been archived by the owner on Jul 13, 2020. It is now read-only.
0.17 wip #346
Merged
0.17 wip #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
0.17
branch
2 times, most recently
from
f81c3c3 to
537e7d2
Compare
|
Wa Sounds good ! 👍 |
|
Just to konw, what led you to remove this built-in Promise polyfilling by default ? I was dreaming about it later ;) |
|
Promises weren't implemented in browsers initially when this spec work was implemented. Also when promises were implemented natively they were initially slower than the library implementations. I just tested yesterday and Promises are definitely now marginally faster than the when.js implementation, making it suitable. |
guybedford
force-pushed
the
0.17
branch
4 times, most recently
from
0b62ce2 to
65fe5b6
Compare
|
Nearly ready to land here... |
guybedford
force-pushed
the
0.17
branch
3 times, most recently
from
a08104a to
e949427
Compare
* Comparing specificity for exact match made no sense * Comparing specificity for wildcard branch now * Measure specificity as number of slashes rather than absolute length
|
@guybedford What's the plan for future development? Are you planning further work for 0.18 or whatever, or are you going to be concentrating on 1.0 and the new spec? |
|
ok, thanks. It's frustrating that nothing's happened on the spec for several months now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promise no longer bundled