Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to open folder recursively #50

Closed
wants to merge 1 commit into from

Conversation

FLeXyo
Copy link

@FLeXyo FLeXyo commented Feb 20, 2021

I added the option to open a folder recursively because I needed it for personal use, but I thought that I might as well make a PR for it in case you think it's a good idea.

Potential improvements:

  • Add the Microsoft.WindowsAPICodePack-Shell package so we can use CommonOpenFileDialog with the IsFolderPicker property set instead of the awful FolderBrowserDialog. I didn't want to do this without asking since it requires a package to be added.
  • Change the "Open file" button to a ToolStripSplitButton and add the recursive option under it. I tried this approach but the dark mode theming didn't seem to work properly with the split button, so I abandoned the idea as I have never worked with Windows Forms before.

I would rebase from master, but the conflicts in the resx files scare me and I haven't worked with Windows Forms before.

@Beelink
Copy link
Member

Beelink commented Feb 20, 2021

Thank you for the good idea! I will try to implement it.

P.S.
I use self-made library for the dark mode so you almost had no way to implement dark mode by yourself.

Beelink added a commit that referenced this pull request Feb 23, 2021
Added:
- Open folder recursively (#50)
- Settings -> Localization: "Help us to translate the app" button

Fixed:
- Can't select a CR2 file to open
@Beelink
Copy link
Member

Beelink commented Feb 23, 2021

Now it looks like this:

image

You can check how it works by downloading the binaries from here:
https://github.com/ModuleArt/quick-picture-viewer/tree/master/quick-picture-viewer/bin/Debug

@Beelink Beelink closed this Feb 23, 2021
Beelink added a commit that referenced this pull request Mar 1, 2021
Changes:
- Fix a lot of issues related to the Selection tool
- Update all dependencies
- New open-folder dialog (#50)
- Replace NavPanel by NavForm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants