Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on starting #2

Closed
bccrew opened this issue Jul 7, 2020 · 14 comments
Closed

Crash on starting #2

bccrew opened this issue Jul 7, 2020 · 14 comments
Assignees
Labels
🐞 bug Something isn't working 🦌 enhancement Improve existing feature 🥇 good first issue Good for newcomers

Comments

@bccrew
Copy link

bccrew commented Jul 7, 2020

Hello, running updated Windows 10 64bit.
When I run quick-picture-viewer.exe it doesn't open. Event viewer says the following:

Application: quick-picture-viewer.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.UnauthorizedAccessException
at Microsoft.WindowsAPICodePack.Taskbar.JumpList.AppendCustomCategories()
at Microsoft.WindowsAPICodePack.Taskbar.JumpList.Refresh()
at quick_picture_viewer.CustomJumplist..ctor(IntPtr)
at quick_picture_viewer.MainForm..ctor(System.String, Boolean)
at quick_picture_viewer.Program.Main(System.String[])

Running as administrator doesn't make any difference.

Faulting application name: quick-picture-viewer.exe, version: 1.12.5.0, time stamp: 0xb88937e9
Faulting module name: KERNELBASE.dll, version: 10.0.18362.815, time stamp: 0xb89efff3
Exception code: 0xe0434352
Fault offset: 0x000000000003a799
Faulting process ID: 0x2620
Faulting application start time: 0x01d654b1dc1287e2
Faulting application path: C:\Program Files (x86)\Module Art\Quick Picture Viewer\quick-picture-viewer.exe
Faulting module path: C:\WINDOWS\System32\KERNELBASE.dll
Report ID: 56fb4117-e31e-44c7-82c7-7e81b6062606
Faulting package full name:
Faulting package-relative application ID:

I attached a WER file and the export of the event viewer logs for you to review.
logs.zip

@Beelink Beelink self-assigned this Jul 8, 2020
@Beelink Beelink added 🐞 bug Something isn't working 🥇 good first issue Good for newcomers labels Jul 8, 2020
@Beelink
Copy link
Member

Beelink commented Jul 8, 2020

I made a couple of moves in this direction. Can you check it again?

To check, download these files:
https://github.com/ModuleArt/quick-picture-viewer/tree/master/quick-picture-viewer/bin/Debug
and run quick-picture-viewer.exe

Thanks.

@bccrew
Copy link
Author

bccrew commented Jul 8, 2020

Hello,

The application still throws an error when opening a picture. I can click continue and then I can use your application.

image

_See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.UnauthorizedAccessException: Custom categories cannot be added while recent documents tracking is turned off.
at Microsoft.WindowsAPICodePack.Taskbar.JumpList.AppendCustomCategories()
at Microsoft.WindowsAPICodePack.Taskbar.JumpList.Refresh()
at quick_picture_viewer.CustomJumplist.BuildList() in D:\Projects\DotNet\quick-picture-viewer\quick-picture-viewer\CustomJumplist.cs:line 29
at quick_picture_viewer.CustomJumplist..ctor(IntPtr windowHandle) in D:\Projects\DotNet\quick-picture-viewer\quick-picture-viewer\CustomJumplist.cs:line 16
at quick_picture_viewer.MainForm.MainForm_Shown(Object sender, EventArgs e) in D:\Projects\DotNet\quick-picture-viewer\quick-picture-viewer\MainForm.cs:line 1621
at System.Windows.Forms.Form.OnShown(EventArgs e)
at System.Windows.Forms.Control.InvokeMarshaledCallbackHelper(Object obj)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Windows.Forms.Control.InvokeMarshaledCallback(ThreadMethodEntry tme)
at System.Windows.Forms.Control.InvokeMarshaledCallbacks()

************** Loaded Assemblies **************
mscorlib
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4180.0 built by: NET48REL1LAST_B
CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll

quick-picture-viewer
Assembly Version: 1.13.0.0
Win32 Version: 1.13.0
CodeBase: file:///C:/Program%20Files%20(x86)/Module%20Art/Quick%20Picture%20Viewer/quick-picture-viewer.exe

System.Windows.Forms
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4150.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll

System
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4001.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll

System.Drawing
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0 built by: NET48REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll

QuickLibrary
Assembly Version: 2.0.0.0
Win32 Version: 2.0.0
CodeBase: file:///C:/Program%20Files%20(x86)/Module%20Art/Quick%20Picture%20Viewer/QuickLibrary.DLL

System.Configuration
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0 built by: NET48REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll

System.Core
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4180.0 built by: NET48REL1LAST_B
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll

System.Xml
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0 built by: NET48REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

Accessibility
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3752.0 built by: NET48REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll

Microsoft.WindowsAPICodePack.Shell
Assembly Version: 1.1.0.0
Win32 Version: 1.1.0.0
CodeBase: file:///C:/Program%20Files%20(x86)/Module%20Art/Quick%20Picture%20Viewer/Microsoft.WindowsAPICodePack.Shell.DLL

Microsoft.WindowsAPICodePack
Assembly Version: 1.1.2.0
Win32 Version: 1.1.2.0
CodeBase: file:///C:/Program%20Files%20(x86)/Module%20Art/Quick%20Picture%20Viewer/Microsoft.WindowsAPICodePack.DLL

WindowsBase
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4180.0 built by: NET48REL1LAST_B
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/WindowsBase/v4.0_4.0.0.0__31bf3856ad364e35/WindowsBase.dll

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box._

I also have an issue where a picture that is opened, is rotated wrong.

In my folder:
image

After opening:
image

I can rotate it within the application but I wonder why it's not displayed as in the preview thumbnail of windows 10.

@Beelink
Copy link
Member

Beelink commented Jul 8, 2020

Can u send me this image?

@bccrew
Copy link
Author

bccrew commented Jul 8, 2020

I have 2 examples. In Windows 10 photos application they with the correct "rotation".

https://www.dropbox.com/s/9pcstxoaxgja6mr/2020-07-01%2021.00.09.jpg?dl=0

https://www.dropbox.com/s/9ruze89ogzvnexq/2020-07-01%2016.32.25.jpg?dl=0

@8thWond3r
Copy link

8thWond3r commented Jul 9, 2020

Hello,

The application still throws an error when opening a picture. I can click continue and then I can use your application.

image

I get this error too. And also please add DDS format support and some mouse control settings such as wheel to zoom. I don't use ctrl+wheel, so it would be nice to toggle that setting to only wheel.

I really like the PiP mode, helps me greatly whenever I need a reference image on top of my workflow. It would be nice if I could zoom images in pip mode too.

@Beelink
Copy link
Member

Beelink commented Jul 9, 2020

"DDS format support" - Done!
"some mouse control settings such as wheel to zoom" - Done!
"I get this error too" - Done!

Check Out here:
https://github.com/ModuleArt/quick-picture-viewer/tree/master/quick-picture-viewer/bin/Debug

"zoom images in pip mode" - Later.

@8thWond3r
Copy link

Wow that was quick. Thanks, I will check it out surely.

@8thWond3r
Copy link

8thWond3r commented Jul 10, 2020

"DDS format support" - Done!
"some mouse control settings such as wheel to zoom" - Done!
"I get this error too" - Done!

Check Out here:
https://github.com/ModuleArt/quick-picture-viewer/tree/master/quick-picture-viewer/bin/Debug

"zoom images in pip mode" - Later.

Hi,
I found two issues while working with DDS files :

  • application throws an error while pressing right arrow to browse the next DDS file in the folder.
  • the viewer's background gets distorted when panning a zoomed image.

here take a look:
new

@8thWond3r
Copy link

DDS support is amazing. It opens all the dds formats which even ImageGlass couldn't open.
I have set this app as my default image viewer so may I suggest some small but necessary features to improve this app even more:

  • option to toggle the window context dialog "Browse folder with quickpictureviewer"
  • different icons for different file formats.
  • button to toggle the transparency if an image has one.
  • option to set a default external app like Photoshop,etc.

P.S. Thanks for developing all these lightweight apps which are fast and kind on the memory and CPU.
I have installed all your quick apps and hope you keep maintaining and updating them in future.

@Beelink Beelink added the 🦌 enhancement Improve existing feature label Jul 10, 2020
@Beelink
Copy link
Member

Beelink commented Jul 11, 2020

Done:

  • "application throws an error while pressing right arrow to browse the next DDS file in the folder" - Fixed;
  • "zoom images in pip mode" - Added.

Troubles:

  • "the viewer's background gets distorted when panning a zoomed image" - It cannot be fixed in a simple way, but I will look for different methods of solution;
  • "button to toggle the transparency if an image has one" - Explain to me how this will work (just lay a white / black background instead of transparency?).

Will be added later:

  • "option to toggle the window context dialog 'Browse folder with quickpictureviewer'";
  • "different icons for different file formats";
  • "option to set a default external app like Photoshop,etc".

@8thWond3r
Copy link

* "button to toggle the transparency if an image has one" - Explain to me how this will work (just lay a white/black background instead of transparency?).

Yeah, a black/white background depending on the system theme would be fine or you could add an option to select our own color for transparent space.

have a look at this program "DDS converter". Blue area is transparent and you can change that color to different ones to easily distinguish between foreground objects and the background.
Annotation 2020-07-12 130930

@Beelink
Copy link
Member

Beelink commented Jul 14, 2020

"option to set a default external app like Photoshop,etc" - Done:

image
image

"button to toggle the transparency if an image has one" - Done:

image
image

@Beelink
Copy link
Member

Beelink commented Jul 26, 2020

"different icons for different file formats" - Done:

image
image

Everything will be implemented in 2.0.0 major release.
Options to toggle explorer context menu for 'Browse folder with QuickPictureViewer' and 'Open with QuickPictureViewer' will be implemented in one of the next releases.

Beelink added a commit that referenced this issue Oct 25, 2020
Added:
- Settings -> Windows: Open with QuickPictureViewer (#23, #2)
- Settings -> Windows: Browse folder with QuickPictureViewer (#23, #2)

Changes:
- QuickLibrary v2.2.4
@Beelink
Copy link
Member

Beelink commented Oct 25, 2020

@Beelink Beelink closed this as completed Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🦌 enhancement Improve existing feature 🥇 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants