Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on deprecated gulp-util #46

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Drop dependency on deprecated gulp-util #46

merged 2 commits into from
Jan 17, 2018

Conversation

TheDancingCode
Copy link
Contributor

gulp-util has been deprecated recently. Continuing to use this dependency may prevent the use of your library with the recently released version 4 of Gulp, it is important to replace gulp-util.

Your package is popular but still relying on gulp-util, it would be good to publish a fixed version to npm as soon as possible.

@phated
Copy link

phated commented Jan 4, 2018

@doctyper any word on getting this merged? Also, through2 should be updated (it's super out of date)

@TheDancingCode
Copy link
Contributor Author

@phated I added an update of through2. As for getting it merged, it's only been 2 hours.

@rejas
Copy link
Member

rejas commented Jan 8, 2018

Tracking of gulp-util migration is done here: gulpjs/gulp-util#143

@rejas
Copy link
Member

rejas commented Jan 14, 2018

Using the branch of this PR solves also #45
So I am totally for merging it sooner than later.

@rejas
Copy link
Member

rejas commented Jan 17, 2018

@doctyper are you still maintining this or can I help you out here?

@doctyper
Copy link
Member

@rejas Thank you for volunteering. I am not actively maintaining this project, no. I've added you as a contributor.

Let me know if you'd like ownership of this repository and I can transfer it over.

@rejas
Copy link
Member

rejas commented Jan 17, 2018

Thx for the info. I wouldnt mind maintaining it so feel free to transfer it

@rejas rejas merged commit d4d47d7 into Modernizr:develop Jan 17, 2018
@doctyper
Copy link
Member

@rejas All set. Thanks again.

@rejas
Copy link
Member

rejas commented Jan 17, 2018

@doctyper Thanks to you too! Any idea if you have to transfer the npm entry too: https://www.npmjs.com/package/gulp-modernizr ? Or does that happen automatically too? Got the same username there in case.

@doctyper
Copy link
Member

👍 Added you as an owner

@phated
Copy link

phated commented Jan 17, 2018

Be sure to publish as a major change

@rejas
Copy link
Member

rejas commented Jan 17, 2018

I am wondering if publishing as "1.0.0" would be enough. Currently its 1.0.0-alpha. Would that trigger it or do I need to go v2 already?

@phated
Copy link

phated commented Jan 17, 2018

@rejas that's a tricky thing. npm has never been good at handling semver with prerelease versions (I think the behavior has changed between npm versions) - this is why the gulp 4 alphas were never published to npm - so it might be best to just bump to 2.0.0

@doctyper
Copy link
Member

I've never had an issue bumping alpha versions. 1.0.0 should be fine.

@rejas
Copy link
Member

rejas commented Jan 17, 2018

@phated thx for the input, will do a v2 release of the develop branch. probably also will release the old master as v1.0.0 without the alpha tag to end that line.

@phated
Copy link

phated commented Jan 17, 2018

@doctyper it's not a problem of bumping - the problem stems from people potentially receiving breaking changes due to using a semver range on a prerelease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants