-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop dependency on deprecated gulp-util
#46
Conversation
@doctyper any word on getting this merged? Also, through2 should be updated (it's super out of date) |
@phated I added an update of through2. As for getting it merged, it's only been 2 hours. |
Tracking of gulp-util migration is done here: gulpjs/gulp-util#143 |
Using the branch of this PR solves also #45 |
@doctyper are you still maintining this or can I help you out here? |
@rejas Thank you for volunteering. I am not actively maintaining this project, no. I've added you as a contributor. Let me know if you'd like ownership of this repository and I can transfer it over. |
Thx for the info. I wouldnt mind maintaining it so feel free to transfer it |
@rejas All set. Thanks again. |
@doctyper Thanks to you too! Any idea if you have to transfer the npm entry too: https://www.npmjs.com/package/gulp-modernizr ? Or does that happen automatically too? Got the same username there in case. |
👍 Added you as an owner |
Be sure to publish as a major change |
I am wondering if publishing as "1.0.0" would be enough. Currently its 1.0.0-alpha. Would that trigger it or do I need to go v2 already? |
@rejas that's a tricky thing. npm has never been good at handling semver with prerelease versions (I think the behavior has changed between npm versions) - this is why the gulp 4 alphas were never published to npm - so it might be best to just bump to 2.0.0 |
I've never had an issue bumping alpha versions. 1.0.0 should be fine. |
@phated thx for the input, will do a v2 release of the develop branch. probably also will release the old master as v1.0.0 without the alpha tag to end that line. |
@doctyper it's not a problem of bumping - the problem stems from people potentially receiving breaking changes due to using a semver range on a prerelease. |
gulp-util
has been deprecated recently. Continuing to use this dependency may prevent the use of your library with the recently released version 4 of Gulp, it is important to replacegulp-util
.Your package is popular but still relying on
gulp-util
, it would be good to publish a fixed version to npm as soon as possible.