Skip to content

Feature Request: Add the ability to control brightness for desktop PCs with/without multi monitor setup #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WindowsFanBoi opened this issue Oct 12, 2020 · 10 comments
Assignees
Milestone

Comments

@WindowsFanBoi
Copy link

In #56, @GabrielCereals proposed to implement the ability to trigger volume/brightness flyout using hotkeys.

And @ShankarBUS said that it will be considered in a future release.

So there is a high chance that desktop users such as me would like to control their monitor brightness using ModernFlyouts.
As he said the WMI methods could not control brightness of desktop monitors. And the users will be disappointed.

There are already some other programs which can control laptop/desktop monitors' brightness such as blackholeearth/Win10_BrightnessSlider & nik9play/tinyBrightness.

Those two projects are really great and are enough for me. But they are not actively maintained and don't have much traction.

My proposal will be a great addition to this project.

I hope you could do this.

Could you use their source code? It will save you some time and work. Please contact the maintainers of those apps and ask them if you can use their source code.

@ShankarBUS
Copy link
Member

@Samuel12321, should we do this?

Is it out of our scope?

@ShankarBUS ShankarBUS changed the title Feature Proposal: Add the ability to control brightness for desktop PCs with/without multi monitor setup Feature Request: Add the ability to control brightness for desktop PCs with/without multi monitor setup Oct 12, 2020
@Samuel12321
Copy link
Member

It seems more like a power toys thing, they have a feature request for it here.
With that being said we could look into it, it would definitely provide the user with more options / features.
Would definitely be a post V1.0 thing.

@ShankarBUS
Copy link
Member

Yep, its better leave this to experts.

@ShankarBUS ShankarBUS self-assigned this Oct 17, 2020
@ShankarBUS ShankarBUS added the Good First Issue Good for newcomers label Oct 22, 2020
@WindowsFanBoi
Copy link
Author

WindowsFanBoi commented Nov 2, 2020

Don't bring up the PowerToys issue!

It's like a year old? They haven't made any progress!

They have other priorities to focus on. It may take them longer to implement this. That's why I came here in the hope of some help.

Adding this feature would help fillin up the gap in the brightness flyout settings page 😂, wouldn't it?

How is this out of scope for you guys? ModernFlyouts = modern flyouts, isn't it?

Come on, you are even adding extra features to the media controls which are not present in the Windows provided one. Like app info, timeline info,....

Why not do this simple thing?!!!

@ShankarBUS
Copy link
Member

Not only "out-of-scope" but "out-of-our-knowledge/capacity/work limit" and I'm not risking anything. I don't want to break the app.

I do understand you need a single software to control all of them in one place. But why should we remake what's already there?

Aren't the apps you linked working fine?

Until we implement this in the future, could you keep using them?

I'm not sure of a timeframe of when we'll complete this. But I will somehow implement this bit by bit.
Our first part to this implementation would be done together with the auto flyout placement feature (I would add display/screen helpers for detecting displays, finding their bounds).

And I will then add the methods to actually control the brightness of them. Each monitor has a HMONITOR associated with them which we can use to find their bounds or even control brightness. As half of the work require for this will be done with the auto placement feature, I see this as completely possible.

So, you may believe this feature will make it to v1.0?

@prakharb5
Copy link
Member

Will this feature be for v0.9 or v1? Just confirming.

@ShankarBUS
Copy link
Member

Bruh go use https://github.com/xanderfrangos/twinkle-tray. It's much better than our app.

@prakharb5
Copy link
Member

prakharb5 commented Jan 10, 2021

I am using. But the fact that the default flyout comes up bugs me.

Edit -- nvm, i just saw another issue and understood that twinkle tray creates their own window.

@ShankarBUS
Copy link
Member

Yo it's not the native flyout!
The show a custom look-alike. Why should we support that?

@prakharb5
Copy link
Member

Understood.

ShankarBUS added a commit that referenced this issue May 27, 2021
- Guess what OwO? Muwti-monitow bwightness contwow APIs UwU #102
- More MVVM
- Fixed a bug where dragging the flyout breaks the placement mode setting
@Samuel12321 Samuel12321 added this to the 0.10.5 milestone May 28, 2021
@Samuel12321 Samuel12321 modified the milestones: 0.10.5, 0.10 Jun 19, 2021
@ShankarBUS ShankarBUS mentioned this issue Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants