-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command line platforms that support event loops and workers (win, mac, lin) #528
Open
cmidgley
wants to merge
37
commits into
Moddable-OpenSource:public
Choose a base branch
from
cmidgley:x-cli
base: public
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a command line (headless) platform for Windows, Mac and Linux. Full support for the event loop, including timers, promises, and workers. Introduces new platform types of
cli-mac
,cli-win
, andcli-lin
. Supports dynamic mod loading by specifying the path to the archive (xsa
) file as the first argument to the cli program. Updated many manifest files to support these platforms (though there are others likely still needing to be added, which should be fairly easy as they are discovered and tested).The new code is mostly under
contibuted/cli
, however many manifest files in the primary code base had to be adjusted to include the new platform types. I believe these changes will not break any existing builds or code as they changes should only come into play when thecli-XXX
platform types are used.See the included README file in the
contibuted/cli
folder for usage information. Since it is using a new platform type, usage is as simple asmcconfig -m -p cli-mac
(or whatever platform you want), and then running the resulting application. Examples which do not depend on the screen, and are supported on the host platform, should work "out of the box". This does mean, however, that production code is automatically includingcontibuted
content (only when-p cli-XXX
is used). If this is not acceptable, a solution would be to revert theexamples/manifest_base.json
file and add that file instead tocontributed/manifest_base.json
(though any example or code base would then need the manifest changed to be tested with cli).Also includes:
Fixes #522