Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import failed in mod #1232

Closed
stc1988 opened this issue Oct 10, 2023 · 3 comments
Closed

import failed in mod #1232

stc1988 opened this issue Oct 10, 2023 · 3 comments
Labels
confirmed issue reported has been reproduced fixed - please verify Issue has been fixed. Please verify and close.

Comments

@stc1988
Copy link
Contributor

stc1988 commented Oct 10, 2023

Build environment: macOS
Moddable SDK version: d0a90fa
Target device: M5stack

Steps to Reproduce

  1. Build and install host app contributed/ble/hid-peripheral/host using this build command: mcconfig -d -m -p mac
  2. Build and install mod app contributed/ble/hid-peripheral/mod-media using this build command: mcrun -d -m -p mac
  3. I got below error in xsbug
/Users/satoshi/Projects/moddable/contributed/ble/hid-peripheral/host/main.js (29) # Break: importNow: import VolumeDownSkin not found!

I got similar errors in other mods mod-keyboard and mod-combo
/Users/satoshi/Projects/moddable/contributed/ble/hid-peripheral/host/main.js (29) # Break: importNow: import BottomRowTexture not found!

@phoddie
Copy link
Collaborator

phoddie commented Oct 10, 2023

Interesting. I get the same error. The assets module exports appears to be correct:

If I remove the import and use of VolumeDownSkin, the mod launches normally.

We'll investigate Thank you.

@phoddie phoddie added the confirmed issue reported has been reproduced label Oct 10, 2023
@phoddie
Copy link
Collaborator

phoddie commented Oct 11, 2023

We tracked down the problem to a long-standing bug in the linker that only triggers when building mods. It was difficult to trigger, however. This particular issue likely only appeared because of another recent fix (#1209) to the linker. The fix will be included in Moddable SDK 4.2.1. It will be necessary to do a clean rebuild of the mod.

mkellner pushed a commit that referenced this issue Oct 11, 2023
@phoddie phoddie added the fixed - please verify Issue has been fixed. Please verify and close. label Oct 11, 2023
@stc1988
Copy link
Contributor Author

stc1988 commented Oct 12, 2023

I confirmed this issue fixed in Moddable SDK 4.2.1.

@stc1988 stc1988 closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed issue reported has been reproduced fixed - please verify Issue has been fixed. Please verify and close.
Projects
None yet
Development

No branches or pull requests

2 participants