Settings rework #808
Merged
Settings rework #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split general tab
split nexus tab
split steam tab
fixed log and crash dump directory links in label not working
removed Settings::query(), main window now deals with SettingsDialog directly
removed commented out code reordered member functions in Settings
apparently, QFontMetrics::width() is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an easy one. It's just a split of the different settings tabs to individual files. All the UI has been removed from
Settings. There is no change in functionality.I had to add a few temporary member functions to
Settingsand I moved some private member variables to be public. All of this will be cleaned up in my next PR, which will be a redesign of the settings to avoid usingQSettingsall over the place.Following a discussion with Al, I've also removed all the load mechanisms since we only support direct loading now.