Add plugin setting to enable/disable LOOT & add loot & display name #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & nexusName # Motivations While LOOT has been always disabled for this plugin, the FalloutNV LOOT list has been recieving a lot of recent attention https://github.com/loot/falloutnv/commits/v0.21/, so it'd be nice to start offering the option to enable LOOT sorting # Modifications - Add a plugin setting to enable the LOOT sorting button - Updated `gameName()` to "Tale of Two Wastelands" which is more appropriate than just "TTW" - LOOT wasn't working out of the box as the `gameShortName()` was "TTW", this needed to be changed to "FalloutNV" so that the LOOT cli could be started with the appropriate game switch - `gameNexusName()` was empty, FalloutNV is appropriate enough for this, while TTW installs can contain both Fallout NV and Fallout 3 nexus mods, 99% of the time Nexus mods will come from the Fallout NV nexus
Twinki14
changed the title
name()'s..name()'s
Holt59
reviewed
May 17, 2024
Holt59
reviewed
May 17, 2024
Holt59
reviewed
May 17, 2024
|
This is more of a meta conversation but the reason these game plugins generally include the gamebryo translations was because translations are loaded based on plugin filenames. Since gamebryo is not an actual plugin, gamebryo translations are not loaded on their own. I think maybe we simplified this at some point but I'm still concerned that those translations are going to be lost again if they aren't in the final translation file(s). |
Twinki14
added a commit
to Twinki14/modorganizer
that referenced
this pull request
May 20, 2024
# Motivations - ModOrganizer2/modorganizer-game_ttw#36 (comment) Surfaced desires to change the Fallout TTW plugin's gameName to something more obvious, from TTW to Tale of Two Wastelands, but that would cause existing profiles to break, `displayGameName()` added in ModOrganizer2/modorganizer-uibase#141 gives us the option to change the way the game plugin is displayed, but leaves the existing integral `gameName()` alone - Similarly ModOrganizer2/modorganizer-game_ttw#36 attempted to fix the sort button LOOT cli argument by changing the `gameShortName()`, as 'TTW' isn't a valid option for LOOT, but that comes with some pretty concerning possible issues # Modifications - Use `displayGameName()` in create instance dialogs & the main window, this doesn't cover all places `gameName()` was being used for purely display reasons, but it covers the bulk - Use `lootGameName()` instead of `gameShortName()` for LOOT cli initiation
Twinki14
changed the title
..name()'s
|
PR is ready again, note that it relies on ModOrganizer2/modorganizer-uibase#141 to be merged first, and that a build failure is expected until then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
While LOOT has been always disabled for this plugin, the FalloutNV LOOT list has been recieving a lot of recent attention https://github.com/loot/falloutnv/commits/v0.21/, so it'd be nice to start offering the option to enable LOOT sorting
It's worth noting that TTW-related mods are lumped into the FalloutNV LOOT list loot/falloutnv@da3c48e
Modifications
displayGameName()override so that we can purely display a more accurate name for this plugin, "TTW" doesn't really cut itlootGameName()override so that LOOT can successfully be ran for this plugin (TTW is not a valid LOOT game).clang-format, it was missing