Conversation
…via a dedicated store and hydration tracking
…t daemon The terminal-host daemon runs with ELECTRON_RUN_AS_NODE=1 and cannot resolve the electron module. Vite's code splitting bundled electron-dependent code (via local-db) into a shared chunk loaded by terminal-host, causing immediate crash on startup (ELECTRON-X, ELECTRON-Y, ELECTRON-10). Extract buildTerminalEnv and its electron/local-db dependencies into env-terminal.ts, keeping env.ts electron-free so terminal-host/session.ts can safely import buildSafeEnv without pulling in electron.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthrough端末環境構築ロジックを新しい専用モジュール Changes
Sequence DiagramsequenceDiagram
participant Router as ルーター
participant DeepLinkHandler as ディープリンク<br/>ハンドラー
participant Store as ナビゲーション<br/>ストア
participant WorkspacePage as ワークスペース<br/>ページ
participant TabsStore as タブ<br/>ストア
participant FileViewer as ファイル<br/>ビューア
Router->>DeepLinkHandler: onResolved イベント
DeepLinkHandler->>DeepLinkHandler: consumeWorkspaceDeepLink(path)
DeepLinkHandler->>Store: replacePendingWorkspaceIntent({...})
Store->>DeepLinkHandler: インテント保存
DeepLinkHandler->>Router: navigate(resolvedPath)
Router->>WorkspacePage: ワークスペース<br/>ページ表示
WorkspacePage->>Store: pendingIntent 監視開始
par タブ水和待機
TabsStore->>TabsStore: hasHydrated = true
and ペーン準備
WorkspacePage->>WorkspacePage: タブ/ペーン処理
end
WorkspacePage->>TabsStore: 対象タブを選択
WorkspacePage->>Store: markTabHandled()
Store-->>WorkspacePage: tabHandled 更新
WorkspacePage->>FileViewer: ファイル開封<br/>(line/column 指定)
FileViewer->>FileViewer: パス検証
WorkspacePage->>Store: markFileHandled()
Store-->>WorkspacePage: fileHandled 更新
WorkspacePage->>Store: clearPendingIntent()
Store->>Store: インテント クリア
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Summary by CodeRabbit
リリースノート
新機能
改善