Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughブラウザのサイト単位権限管理（カメラ・マイク）を追加し、macOS 向けメディアアクセス要求の共通化、SitePermissions UI/トグル、User-Agent 正規化、PR 添付解決ロジック、ブックマークパーサの刷新、DB スキーマ拡張、ディープリンクの非同期化を導入しています。 変更内容
シーケンス図sequenceDiagram
actor User
participant BrowserPane
participant SitePermissionsMenu as SitePermissionsMenu(UI)
participant TRPC as TRPC Router
participant BrowserSPM as BrowserSitePermissionManager
participant LocalDB as LocalDB
participant Electron as ElectronSystem
User->>BrowserPane: ページ訪問 (paneId, currentUrl)
BrowserPane->>SitePermissionsMenu: 表示要求
SitePermissionsMenu->>TRPC: getSitePermissions(url)
TRPC->>BrowserSPM: getPermissionsForUrl(url)
BrowserSPM->>LocalDB: SELECT origin/kind
LocalDB-->>BrowserSPM: 権限レコード
BrowserSPM-->>TRPC: 権限マップ
TRPC-->>SitePermissionsMenu: 権限を返す
Note over Electron,BrowserSPM: ページ側からメディア要求発生
Electron->>BrowserSPM: permission check/request(media)
BrowserSPM->>LocalDB: 確認/更新
BrowserSPM-->>Electron: allow/deny（保存値基準）
alt ユーザーが UI で許可を選択
SitePermissionsMenu->>TRPC: setSitePermission(origin, kind, "allow")
TRPC->>BrowserSPM: setPermission(...)
BrowserSPM->>LocalDB: upsert
BrowserSPM->>Electron: requestMediaAccess(kind)
Electron->>Electron: macOS: askForMediaAccess -> granted? / openExternal(settings)
Electron-->>BrowserSPM: {granted, openedSystemSettings}
BrowserSPM-->>TRPC: 結果返却
TRPC-->>SitePermissionsMenu: 結果反映
end
推定コードレビュー時間🎯 4 (Complex) | ⏱️ ~75分 関連する可能性のあるプルリクエスト
ポエム
🚥 Pre-merge checks | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Export GitRemoteInfo from existing-pr-push-target - Cast Electron permission details to fix securityOrigin and mediaTypes type errors - Fix useExhaustiveDependencies lint error in BookmarkBarItem - Fix formatter error in BookmarkFolderItem - Fix sidebar-state merge type error for legacy persisted state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
変更内容
テスト方法
Summary by CodeRabbit
リリースノート
新機能
改善