upstream merge 2026-05-08 PR 13: host-service shell env probe + typo#460
Conversation
…perset-sh#4150) Mirrors v1's posture from apps/desktop shell-env.ts: when the login-shell snapshot fails (parse error, non-zero exit, exotic shell, rc files that redirect stdout), log a warning and fall back to process.env + augmentPathForMacOS instead of bringing down host-service startup. Reported by a user who could open v1 workspaces but never v2 — desktop main logged "Failed to start: Failed to parse shell env output - delimiter not found" and process.exit(1)'d before the HTTP server came up. v1 silently falls back via shellEnv()'s catch, which is why only v2 broke. Also pin the snapshot shell's cwd to \$HOME (backport of 4feaa3d, issue superset-sh#4025) and include captured stdout/stderr in the thrown error so the next failure surfaces a diagnosable signal instead of a blind "delimiter not found".
…3993) Co-authored-by: sazabi[bot] <1815759+sazabi[bot]@users.noreply.github.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d29e913f61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| reject( | ||
| new Error( | ||
| `${detail} (shell=${shell}` + | ||
| ` stdout=${truncateForDiagnostics(stdout)}` + |
There was a problem hiding this comment.
The new error construction now embeds truncated stdout/stderr from the shell probe, and resolveTerminalBaseEnv() logs that message verbatim on fallback. Because the probe command runs env, a failing shell startup can leak user-exported secrets (for example tokens from shell rc files) into host-service logs; this is a security regression introduced by this commit’s diagnostics path.
Useful? React with 👍 / 👎.
Recorded as integrated via -s ours after batch PRs #455-#464. Taken via individual PRs: - PR 1 (#455): v2 polish 前半 safe set (9 commits) - PR 2 (#456): v2/host-service polish 中盤 (12 commits) - PR 3 (#457): sidebar polish + jwt API (5 commits) - PR 4 (#458): host-service tRPC retry/cache/timeout (3 commits) - PR 5 (#459): v2 diff pane / file pane polish (2 commits) - PR 7 (#462): host-service v2 canonical workspace.create + attachment store (PR1 superset-sh#3893 + PR2 superset-sh#3916) - PR 11 (#463): agents API + onboarding (7 commits + 1 cleanup) - PR 12 (#464): v1→v2 import flow rewrite (11 commits + 2 follow-ups) - PR 13 (#460): host-service shell env probe + typo (2 commits) - PR 16 (#461): marketplace 19 themes (1 commit) Skipped / deferred (recorded as integrated for behind=0): - PR 6: CLI v1 launch (superset-sh#3898 + 30+ CLI/SDK followups) — defer to dedicated migration - PR 9: v2 PR3 (superset-sh#3940) + revert (superset-sh#4017) — net-zero pair - PR 10: pty-daemon (superset-sh#3896, superset-sh#3971, superset-sh#4054) — fork keeps its terminal-host - PR 14: Slack MCP-v2 (superset-sh#4197, superset-sh#4208) — depends on mcp-v2/sdk divergence - PR 15: onboarding remaining (superset-sh#4115, superset-sh#4125, superset-sh#4214, superset-sh#4213, superset-sh#4222, superset-sh#4225) — depends on fork's deleted setup pages Behind: 0 after this merge.
2 participants
Summary
upstream 同期バッチ第 13 弾。host-service 小修正 + typo fix (2 commits)。
進捗: PR 1-5 マージ済み (31 / 223)、PR 6/7/8/9/10/11/12 進行中、本 PR は orthogonal な小修正。
取り込み内容
除外した commits（PR 7 / PR 8 / PR 12 待ち）
Fork 固有機能ヘルスチェック
githubExtendedprocedure 健在Test plan
bun install成功bun run typecheck全 task greenbun run lintexit 0