feat(desktop): Connect browser automation モーダルのUX改善#379
Merged
Conversation
- pane identity card を "Driven by: <session>" 強調表示に刷新し Connected/Unassigned pill を追加 - ヘッダー直下に Workspace bindings サマリバー (connected / unassigned / needs setup) を常駐 - SessionCard の pill を状況別に更新 (● Driving this pane / Driving: <pane> / Ready · Free) + 3 tag 行を 1 行 sub-line に統合 - McpInstallPanel を全 runtime ready 時に emerald 1 行バナーへ畳む (Manage で展開) - BrowserAutomationList をカード羅列 → status dot + pane ← session 矢印の 1 行テーブル風レイアウトへ
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 29 minutes and 36 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughブラウザ自動化関連のUIを再構成し、BrowserAutomationListのレイアウト更新と幅拡張、SessionConnectModalにワークスペースビューと短縮表示を追加、McpInstallPanelにインストール検出と折りたたみバナーを導入しました（内部UIの表示/振る舞い変更のみ）。 Changes
Sequence Diagram(s)sequenceDiagram
participant User as "User"
participant Modal as "SessionConnectModal"
participant Workspace as "WorkspaceBindingsSummary / WorkspacePanesTab"
participant MCP as "McpInstallPanel (runtime check)"
participant Sessions as "Session list / SessionCard"
User->>Modal: 開く（pane選択）
Modal->>Workspace: workspaceId を派生してバインディング集計取得
Modal->>Sessions: 実行中セッション一覧取得
Modal->>MCP: ランタイムCLIの存在とコマンド一致をチェック
MCP-->>Modal: 準備済みフラグ (claudeReady/codexReady)
Modal->>User: 表示更新（Workspaceタブ / ペインカード / セッションカード / MCPバナー）
User->>Modal: Connect/Change を実行
Modal->>Sessions: セッションをペインに割当（または切替）
Sessions-->>Modal: 割当結果
Modal-->>User: 更新されたペイン状態を表示
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
mock.html (1)
1-7:mock.htmlのリポジトリ同居についての方針確認
mock.htmlはランタイムで使用されず、Tailwind CDN 依存の静的なデザインモックです。リポジトリルートに置くと以下の懸念があります:
- ビルド/配布物と混在し、誤って静的ホスティングされる可能性
- 将来的に UI と乖離しても検知されず、古いまま残りやすい
- モックとしての位置付けが伝わりづらい（
docs/やdesign/配下の方が意図が明確）
docs/design/browser-automation/など設計ドキュメント配下への移動、もしくは PR の説明欄へリンクを貼るだけ（commit しない）という選択肢もあります。現在の配置が意図的であれば、README 等で役割を明記しておくと後続メンテナ向けに親切です。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@mock.html` around lines 1 - 7, The mock.html file is a static Tailwind-based design mock that should not live at the repo root; either move mock.html into a documentation/design path (e.g., docs/design/browser-automation/mock.html) to clarify its role and avoid accidental hosting, or keep it out of the commit and instead add a link to the PR description; if you intentionally keep it at the repo root, add a README entry (referencing mock.html) explaining it is a non-runtime design mock and should not be included in build/distribution or static hosting.apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx (2)
354-425: コンポーネント props の型はinterfaceを推奨
WorkspaceBindingsSummary（Line 358-362）・PaneIdentityCard（Line 419-425）ともインラインの object type で props を宣言しています。同ファイル内のSessionConnectModalPropsはinterfaceで定義されており、リポジトリのガイドラインとも整合しません。新規に追加したサブコンポーネントもinterfaceに寄せると揃います。As per coding guidelines: "Prefer
interfacefor defining object shapes in TypeScript".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx` around lines 354 - 425, Replace the inline object type annotations for WorkspaceBindingsSummary and PaneIdentityCard with named interfaces (e.g., declare interface WorkspaceBindingsSummaryProps { sessions: AutomationSession[]; bindingsByPane: Record<string,string>; onOpenAllPanes: () => void; } and interface PaneIdentityCardProps { paneName: string; paneUrl: string; currentSession: AutomationSession | null; onDisconnect?: () => void; disconnectPending?: boolean; }), then update the component signatures to accept those interfaces (function WorkspaceBindingsSummary(props: WorkspaceBindingsSummaryProps) { ... } and function PaneIdentityCard(props: PaneIdentityCardProps) { ... }) so they match the existing SessionConnectModalProps style and repository guideline preferring interface over inline object types.
646-655:SetupPanelに未使用の props が残っている
session/mcpConfigPath/onCopyは受け取るだけで使われておらず、関数本体はMcpInstallPanelをそのまま返しているだけです。呼び出し側（Line 266-275）でもmcpConfigPathを三項演算で計算しているので、無駄な処理にもなっています。SetupPanelラッパーごと削除するか、最低限serverCommandだけを受け取る形に整理するのがすっきりします。♻️ リファクタ例
呼び出し側:
- <SetupPanel - session={session} - mcpConfigPath={ - session.provider === "Codex" - ? (mcpStatus?.codexConfigPath ?? null) - : (mcpStatus?.claudeConfigPath ?? null) - } - serverCommand={serverCommand} - onCopy={handleCopySnippet} - /> + <McpInstallPanel serverCommand={serverCommand} />これで
SetupPanel定義（Line 646-655）ごと削除でき、未使用のhandleCopySnippet/getSnippetForSessionimport も併せて見直せます。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx` around lines 646 - 655, Remove the unused SetupPanel wrapper or simplify it to only accept serverCommand: delete the SetupPanel function (and its import sites) and directly render <McpInstallPanel serverCommand={serverCommand} /> where it was used, or change SetupPanel signature to ({ serverCommand }: { serverCommand?: ServerCommand }) => <McpInstallPanel serverCommand={serverCommand} />; also remove unused props session, mcpConfigPath, onCopy and clean up related unused imports handleCopySnippet and getSnippetForSession. Ensure callers no longer compute mcpConfigPath for this wrapper if you delete it.apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/components/McpInstallPanel/McpInstallPanel.tsx (1)
100-126: 折りたたみバナー展開後に「閉じる」手段がない点 — 任意の改善
Manage ▾でexpanded=trueにした後は、full panel から折りたたみバナーへ戻す UI がありません。allInstalledのときは「Collapse」ボタンや同じManageコントロールをトグルにすると、誤って展開しても元の静かな状態に戻せて UX が一貫します。💡 提案例
- <button - type="button" - onClick={() => setExpanded(true)} - className="inline-flex items-center gap-0.5 text-[11px] text-muted-foreground hover:text-foreground" - > - Manage - <LuChevronDown className="size-3" /> - </button> + <button + type="button" + onClick={() => setExpanded((v) => !v)} + className="inline-flex items-center gap-0.5 text-[11px] text-muted-foreground hover:text-foreground" + > + Manage + <LuChevronDown className="size-3" /> + </button>併せて、full panel 側にも
allInstalledのとき「Hide」ボタンを出すと双方向になります（初期リリースではスコープ外でも可）。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/components/McpInstallPanel/McpInstallPanel.tsx` around lines 100 - 126, When allInstalled is true the UI only renders the compact banner and the Manage button sets expanded via setExpanded(true) but there is no way to collapse back; update McpInstallPanel to render a corresponding collapse control when expanded (or make the existing Manage button act as a toggle) so users can call setExpanded(false) to return to the compact banner; locate logic using the expanded and allInstalled state and add a button (e.g., "Collapse" or toggled "Manage") that invokes setExpanded(false) in the full-panel render path so the banner can be hidden again.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx`:
- Around line 354-411: The summary currently counts panes across all workspaces
because WorkspaceBindingsSummary's browserPanes filter only checks p.type ===
"webview" and tab existence; fix by scoping to the current workspace: resolve
the workspaceId for the modal (from the current paneId in SessionConnectModal)
and pass that workspaceId into WorkspaceBindingsSummary, then change the
browserPanes filter in WorkspaceBindingsSummary to also require
tabById.get(p.tabId)?.workspaceId === workspaceId (or use tabsById from
useTabsStore if available) so connected/unassigned/needsSetup only reflect panes
in the active workspace and match BrowserAutomationList.tsx's logic.
---
Nitpick comments:
In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/components/McpInstallPanel/McpInstallPanel.tsx`:
- Around line 100-126: When allInstalled is true the UI only renders the compact
banner and the Manage button sets expanded via setExpanded(true) but there is no
way to collapse back; update McpInstallPanel to render a corresponding collapse
control when expanded (or make the existing Manage button act as a toggle) so
users can call setExpanded(false) to return to the compact banner; locate logic
using the expanded and allInstalled state and add a button (e.g., "Collapse" or
toggled "Manage") that invokes setExpanded(false) in the full-panel render path
so the banner can be hidden again.
In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx`:
- Around line 354-425: Replace the inline object type annotations for
WorkspaceBindingsSummary and PaneIdentityCard with named interfaces (e.g.,
declare interface WorkspaceBindingsSummaryProps { sessions: AutomationSession[];
bindingsByPane: Record<string,string>; onOpenAllPanes: () => void; } and
interface PaneIdentityCardProps { paneName: string; paneUrl: string;
currentSession: AutomationSession | null; onDisconnect?: () => void;
disconnectPending?: boolean; }), then update the component signatures to accept
those interfaces (function WorkspaceBindingsSummary(props:
WorkspaceBindingsSummaryProps) { ... } and function PaneIdentityCard(props:
PaneIdentityCardProps) { ... }) so they match the existing
SessionConnectModalProps style and repository guideline preferring interface
over inline object types.
- Around line 646-655: Remove the unused SetupPanel wrapper or simplify it to
only accept serverCommand: delete the SetupPanel function (and its import sites)
and directly render <McpInstallPanel serverCommand={serverCommand} /> where it
was used, or change SetupPanel signature to ({ serverCommand }: {
serverCommand?: ServerCommand }) => <McpInstallPanel
serverCommand={serverCommand} />; also remove unused props session,
mcpConfigPath, onCopy and clean up related unused imports handleCopySnippet and
getSnippetForSession. Ensure callers no longer compute mcpConfigPath for this
wrapper if you delete it.
In `@mock.html`:
- Around line 1-7: The mock.html file is a static Tailwind-based design mock
that should not live at the repo root; either move mock.html into a
documentation/design path (e.g., docs/design/browser-automation/mock.html) to
clarify its role and avoid accidental hosting, or keep it out of the commit and
instead add a link to the PR description; if you intentionally keep it at the
repo root, add a README entry (referencing mock.html) explaining it is a
non-runtime design mock and should not be included in build/distribution or
static hosting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 51b5f29f-56cf-4a28-8b01-78bf4b212385
📒 Files selected for processing (4)
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/BrowserAutomationList/BrowserAutomationList.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/components/McpInstallPanel/McpInstallPanel.tsxmock.html
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b890e94bdc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- WorkspaceBindingsSummary を現在 pane の workspaceId で絞り込み。BrowserAutomationList と数値が一致するように - stale binding (session が live set から消えた状態) でも Disconnect を出せるよう PaneIdentityCard に hasBinding を追加。"Session ended" ラベルと専用案内文を表示
- shortenPaneLabel helper を追加し URL 形式の pane 名を host+短縮パスに圧縮 - ReadyPanel DetailItem "Pane"/"Expected"、SessionCard Reassign pill、footer の reassign 文、PaneIdentityCard に適用 - 全 display 箇所で break-words/title 属性を添え、ツールチップで full 値を残す - BrowserAutomationList の機能を SessionConnectModal に "Workspace" タブとして取り込み。別モーダル起動を廃し、Sessions/Workspace/Permissions の3タブ構成に - Summary bar の "Open all panes view →" はタブ切替に変更し、Workspace タブ選択時は表示しない - Permissions タブを sticky header/footer + scrollable middle に再構成し、トグル行が多い時も Save/Activate が常時見える
|
Only repository collaborators, contributors, or members can run CodeRabbit commands. |
- DialogContent に h=min(840px,85vh) + flex-col を明示し、各タブ content を flex-1 min-h-0 で埋めることで、Sessions/Workspace/Permissions 間でモーダル外形が変動しないように - 各タブ個別の min-h/max-h 指定を削除
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx (1)
410-422: 新規 props 形状はinterfaceに切り出してください。Line 410-422、Line 482-496、Line 586-594 の新規コンポーネント props が inline object type になっています。既存の
SessionConnectModalPropsと同様にinterfaceに寄せると、再利用や差分追跡がしやすくなります。♻️ 修正例
+interface WorkspaceBindingsSummaryProps { + sessions: AutomationSession[]; + bindingsByPane: Record<string, string>; + workspaceId: string | null; + onOpenAllPanes: () => void; + activeTab: "sessions" | "workspace" | "permissions"; +} + function WorkspaceBindingsSummary({ sessions, bindingsByPane, workspaceId, onOpenAllPanes, activeTab, -}: { - sessions: AutomationSession[]; - bindingsByPane: Record<string, string>; - workspaceId: string | null; - onOpenAllPanes: () => void; - activeTab: "sessions" | "workspace" | "permissions"; -}) { +}: WorkspaceBindingsSummaryProps) {+interface PaneIdentityCardProps { + paneName: string; + paneUrl: string; + currentSession: AutomationSession | null; + hasBinding: boolean; + onDisconnect?: () => void; + disconnectPending?: boolean; +} + function PaneIdentityCard({ paneName, paneUrl, currentSession, hasBinding, onDisconnect, disconnectPending, -}: { - paneName: string; - paneUrl: string; - currentSession: AutomationSession | null; - hasBinding: boolean; - onDisconnect?: () => void; - disconnectPending?: boolean; -}) { +}: PaneIdentityCardProps) {+interface WorkspacePanesTabProps { + workspaceId: string | null; + onClose: () => void; + onSwitchToSessions: () => void; +} + function WorkspacePanesTab({ workspaceId, onClose, onSwitchToSessions, -}: { - workspaceId: string | null; - onClose: () => void; - onSwitchToSessions: () => void; -}) { +}: WorkspacePanesTabProps) {As per coding guidelines,
**/*.{ts,tsx}: Preferinterfacefor defining object shapes in TypeScript.Also applies to: 482-496, 586-594
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx` around lines 410 - 422, Extract the inline prop object types into named interfaces: create an interface WorkspaceBindingsSummaryProps for WorkspaceBindingsSummary (replace the inline type block in the function signature), and do the same for the other two components reported at lines 482-496 and 586-594 (give them clear names like <ComponentName>Props matching each component), mirroring the style of the existing SessionConnectModalProps; update the function/component signatures to use the new interfaces and export them if they will be reused.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/components/CdpEndpointCard/CdpEndpointCard.tsx`:
- Around line 60-70: The commands chromeDevtoolsCmdClaude,
chromeDevtoolsCmdCodex, browserUseCmdClaude and browserUseCmdCodex interpolate
unescaped dynamic values (data.httpBase and data.browserUseConfigPath) which can
contain spaces or shell metacharacters; update the code to shell-quote/escape
these dynamic values before embedding them (e.g., a small helper like
quoteForShell that escapes single quotes and wraps the value in single quotes)
and use that helper when building those four command strings so the resulting
copy-paste commands are safe on macOS and other shells.
In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/components/PermissionsTab/PermissionsTab.tsx`:
- Around line 232-243: The Input for editing the preset name (controlled by
draftName, disabled by isBuiltin and updated via setDraftName/setDirty) and the
Switch controls in this component lack accessible names; add an explicit
association by giving the Label an htmlFor/id on the Input (or add a clear
aria-label on the Input) and add descriptive aria-label or aria-labelledby
attributes to each Switch instance so screen readers can identify their purpose;
ensure IDs are unique and the labels describe the control (e.g., "Preset name"
for the Input and specific permission names for each Switch).
In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx`:
- Around line 442-447: The current logic treats panes with a binding but no live
session as "unassigned"; instead detect and surface a separate "stale" /
"session ended" state. Update the counts and branching that use browserPanes,
bindingsByPane and liveSessionIds: compute stalePanes = browserPanes.filter(p =>
bindingsByPane[p.id] && !liveSessionIds.has(bindingsByPane[p.id])); compute
unassignedPanes = browserPanes.filter(p => !bindingsByPane[p.id]); compute
connectedPanes = browserPanes.filter(p => bindingsByPane[p.id] &&
liveSessionIds.has(bindingsByPane[p.id])); then replace uses of
connected/unassigned (and any labels like "Connect" shown in the
SessionConnectModal, and the code paths around needsSetup, PaneIdentityCard
rendering) so stale panes render the same "Session ended" state as
PaneIdentityCard instead of being shown as Unassigned/Connect.
---
Nitpick comments:
In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsx`:
- Around line 410-422: Extract the inline prop object types into named
interfaces: create an interface WorkspaceBindingsSummaryProps for
WorkspaceBindingsSummary (replace the inline type block in the function
signature), and do the same for the other two components reported at lines
482-496 and 586-594 (give them clear names like <ComponentName>Props matching
each component), mirroring the style of the existing SessionConnectModalProps;
update the function/component signatures to use the new interfaces and export
them if they will be reused.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 04ebacbc-6fd0-4bf6-9ef7-b40a20205454
📒 Files selected for processing (3)
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/SessionConnectModal.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/components/CdpEndpointCard/CdpEndpointCard.tsxapps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/SessionConnectModal/components/PermissionsTab/PermissionsTab.tsx
…トカット - CdpEndpointCard: Example setup コマンド群を "▾ Example setup" トグル配下に移動し、デフォルト collapsed に。一度設定すれば再表示が不要な情報なのでノイズを減らす - summary bar: Workspace がタブになったので "Switch to Workspace view →" ボタンを廃止、代わりに "Show setup commands" ボタンを設置 - ボタン押下で Sessions タブに切替えつつ revealSetupToken を bump → CdpEndpointCard 側で Example setup セクションを自動展開
- Summary bar は permissions タブでも表示し、"Show setup commands" ボタンの位置を固定 - PermissionsTab / WorkspacePanesTab の min-h/max-h 固定値を撤去し h-full + min-h-0 に変更。DialogContent 固定高の flex 子要素として正しく伸縮するようになり、PermissionsTab のトグルリストが正しくスクロールし Save/Activate が常に可視化される
- CdpEndpointCard に PlaceholderSetupCommandsCard を追加。実際の WebSocket/HTTP base が確定する前でも setup コマンドのテンプレートを見せる (<port> / <BROWSER_USE_CONFIG_PATH> のプレースホルダ付き) - SessionConnectModal 右カラムで setupRevealToken > 0 かつ選択セッションが未 attach の時にこのカードを表示 - ユーザー動線: pane が未 bind → summary bar "Show setup commands" → 右カラムに template カード → dismiss (×) で閉じる
タブを素早く閉じた際に openDocument の pending request が disposeWorkspace に よって reject される競合は想定内のライフサイクルイベントであり、バグではない。 SessionDisposedError クラスを導入し、sentryMiddleware の既存フィルタパターンに 揃える形で除外することで Sentry のノイズを削減する。 Fixes SUPERSET-DESKTOP-K Fixes SUPERSET-DESKTOP-M
- CdpEndpointCard: httpBase / browserUseConfigPath を POSIX shell single-quote して、スペースや特殊文字を含むパスでもコピーしたコマンドが壊れないように - PermissionsTab: Label↔Input を htmlFor/id で接続、各 Switch に aria-label を付与 - WorkspacePanesTab: stale binding (binding は存在するが live session が落ちた状態) を amber ドット + "Session ended — rebind or disconnect" + "Rebind" ボタンで別状態として表示。PaneIdentityCard と同じ扱いに揃えた - WorkspaceBindingsSummary: stale の件数を amber バッジで表示し unassigned から分離
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景 / 動機
ユーザーから以下の声がありました:
mock.htmlで現状 UI を再現し改善案を作成、本 PR で実装に落とし込みました。変更点
SessionConnectModal
Driven by: <session名>を明示。disconnect ボタンもカード右端に同居BrowserAutomationListにジャンプ● Driving this paneDriving: <pane名>Ready · FreeMcpInstallPanel
BrowserAutomationList (All panes)
参考
mock.htmlに現状 ①②③ / 改善案 ④⑤⑥ を並べて確認できますTest plan
Summary by CodeRabbit
リリースノート
新機能
UI改善
改善