Skip to content

fix(desktop): ReviewパネルのURLをSupersetブラウザペインで開く #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MocA-Love merged 4 commits into from
Mar 30, 2026
Merged

fix(desktop): ReviewパネルのURLをSupersetブラウザペインで開く #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
043efc5
fix(desktop): ReviewパネルのURLをSupersetブラウザペインで開く
MocA-Love Mar 30, 2026
671291b
fix(desktop): workspaceId propを削除しコンテキストから直接取得 + fishテスト更新
MocA-Love Mar 30, 2026
6b5955d
fix(desktop): aタグをbuttonに変更してElectronのナビゲーションを確実に防ぐ
MocA-Love Mar 30, 2026
41341d3
fix(desktop): URLを新規ブラウザタブで開くよう変更
MocA-Love Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/desktop/src/main/lib/agent-setup/shell-wrappers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,7 @@ export SUPERSET_WORKSPACE_PATH="/wrong/path"
expect(args).toEqual([
"-l",
"--init-command",
`set -l _superset_bin "${TEST_BIN_DIR}"; contains -- "$_superset_bin" $PATH; or set -gx PATH "$_superset_bin" $PATH; function _superset_shell_ready --on-event fish_prompt; printf '\\033]777;superset-shell-ready\\007'; functions -e _superset_shell_ready; end`,
`set -l _superset_bin "${TEST_BIN_DIR}"; contains -- "$_superset_bin" $PATH; or set -gx PATH "$_superset_bin" $PATH; function _superset_shell_ready --on-event fish_prompt; printf '\\033]777;superset-shell-ready\\007'; functions -e _superset_shell_ready; end; function _superset_prompt_marker --on-event fish_prompt; printf '\\033]777;superset-prompt\\007'; end`,
]);
});

Expand All @@ -853,7 +853,7 @@ export SUPERSET_WORKSPACE_PATH="/wrong/path"
expect(args).toEqual([
"-l",
"--init-command",
`set -l _superset_bin "/tmp/with space/quote\\"buck\\$slash\\\\bin"; contains -- "$_superset_bin" $PATH; or set -gx PATH "$_superset_bin" $PATH; function _superset_shell_ready --on-event fish_prompt; printf '\\033]777;superset-shell-ready\\007'; functions -e _superset_shell_ready; end`,
`set -l _superset_bin "/tmp/with space/quote\\"buck\\$slash\\\\bin"; contains -- "$_superset_bin" $PATH; or set -gx PATH "$_superset_bin" $PATH; function _superset_shell_ready --on-event fish_prompt; printf '\\033]777;superset-shell-ready\\007'; functions -e _superset_shell_ready; end; function _superset_prompt_marker --on-event fish_prompt; printf '\\033]777;superset-prompt\\007'; end`,
]);
});
});
Expand Down
52 changes: 39 additions & 13 deletions .../components/WorkspaceView/RightSidebar/ChangesView/components/ReviewPanel/ReviewPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
import { Skeleton } from "@superset/ui/skeleton";
import { toast } from "@superset/ui/sonner";
import { cn } from "@superset/ui/utils";
import { useEffect, useRef, useState } from "react";
import { useCallback, useEffect, useRef, useState } from "react";
import {
LuArrowUpRight,
LuCheck,
Expand All @@ -24,6 +24,8 @@ import remarkGfm from "remark-gfm";
import { remarkAlert } from "remark-github-blockquote-alert";
import { electronTrpc } from "renderer/lib/electron-trpc";
import { PRIcon } from "renderer/screens/main/components/PRIcon";
import { useWorkspaceId } from "renderer/screens/main/components/WorkspaceView/WorkspaceIdContext";
import { useTabsStore } from "renderer/stores/tabs";
import { CheckSteps } from "./components/CheckSteps";
import {
ALL_COMMENTS_COPY_ACTION_KEY,
Expand Down Expand Up @@ -57,6 +59,19 @@ export function ReviewPanel({
isCommentsLoading = false,
onOpenFile,
}: ReviewPanelProps) {
const resolvedWorkspaceId = useWorkspaceId();
const addBrowserTab = useTabsStore((s) => s.addBrowserTab);
const handleOpenUrl = useCallback(
(url: string, e: React.MouseEvent) => {
e.preventDefault();
e.stopPropagation();
if (resolvedWorkspaceId) {
addBrowserTab(resolvedWorkspaceId, url);
}
},
[resolvedWorkspaceId, addBrowserTab],
);
Comment thread
MocA-Love marked this conversation as resolved.

const [checksOpen, setChecksOpen] = useState(true);
const [commentsOpen, setCommentsOpen] = useState(true);
const [resolvedCommentsGroupOpen, setResolvedCommentsGroupOpen] =
Expand Down Expand Up @@ -271,6 +286,20 @@ export function ReviewPanel({
<ReactMarkdown
remarkPlugins={[remarkGfm, remarkAlert]}
rehypePlugins={[rehypeRaw, rehypeSanitize]}
components={{
a: ({ href, children }) =>
href ? (
<a
href={href}
className="text-primary underline"
onClick={(e) => handleOpenUrl(href, e)}
>
{children}
</a>
) : (
<span>{children}</span>
),
}}
>
{stripHtmlComments(comment.body)}
</ReactMarkdown>
Expand All @@ -280,16 +309,14 @@ export function ReviewPanel({

<div className="absolute right-1 top-1 flex flex-col gap-1 opacity-0 transition-opacity group-hover:opacity-100 group-focus-within:opacity-100">
{comment.url ? (
<a
href={comment.url}
target="_blank"
rel="noopener noreferrer"
<button
type="button"
className="inline-flex size-4 items-center justify-center rounded-sm text-muted-foreground transition-colors hover:bg-accent hover:text-foreground"
aria-label="Open comment on GitHub"
onClick={(e) => e.stopPropagation()}
onClick={(e) => handleOpenUrl(comment.url as string, e)}
>
<LuArrowUpRight className="size-3" />
</a>
</button>
) : null}
<button
type="button"
Expand All @@ -315,11 +342,10 @@ export function ReviewPanel({
return (
<div className="flex h-full min-h-0 flex-col overflow-y-auto">
<div className="px-2 py-2 space-y-1.5">
<a
href={pr.url}
target="_blank"
rel="noopener noreferrer"
className="group flex items-center gap-1.5 cursor-pointer"
<button
type="button"
className="group flex w-full items-center gap-1.5 cursor-pointer text-left"
onClick={(e) => pr.url && handleOpenUrl(pr.url, e)}
>
<PRIcon state={pr.state} className="size-4 shrink-0" />
<span
Expand All @@ -329,7 +355,7 @@ export function ReviewPanel({
{pr.title}
</span>
<LuArrowUpRight className="size-3.5 shrink-0 text-muted-foreground/70 opacity-0 transition-opacity group-hover:opacity-100" />
</a>
</button>
<div className="flex items-center gap-1.5">
<span
className={cn(
Expand Down
Loading