desktop: add reusable terminal sentry debug instrumentation#341
desktop: add reusable terminal sentry debug instrumentation#341
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 43 minutes and 49 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d2e9c6dbe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "ws-connect-start", | ||
| { | ||
| terminalId: transport.debugId, | ||
| wsUrl, |
There was a problem hiding this comment.
Redact websocket token before debug capture
ws-connect-start sends the full wsUrl to Sentry with captureMessage: true, which leaks credentials because useWorkspaceWsUrl appends the workspace auth token as a token query param (packages/workspace-client/src/providers/WorkspaceClientProvider/WorkspaceClientProvider.tsx, useWorkspaceWsUrl). This runs on every connect/reconnect, so active workspace tokens can be exposed in telemetry payloads; log only sanitized URL parts (e.g., path/host) or explicitly strip sensitive query keys before capture.
Useful? React with 👍 / 👎.
Summary
What Changed
apps/desktop/src/shared/debug-channel.tsに再利用可能な debug channel 基盤を追加apps/desktop/src/main/lib/debug-channel.tsとapps/desktop/src/renderer/lib/debug-channel.tsに Sentry transport を追加terminal.host/terminal.rendererの調査ログ入口を追加Verification
bunx @biomejs/biome@2.4.2 check --write <edited files>bun run --cwd apps/desktop typecheckは既存の CodeMirror /@codemirror/viewversion mismatch で失敗v1-terminal-cache.tsの呼び出し漏れは修正済み