feat(desktop): TODO composer に PTY / Remote Control トグルを追加#320
Merged
feat(desktop): TODO composer に PTY / Remote Control トグルを追加#320
Conversation
TodoManager 内のインライン composer (「新しい TODO」カード) にも TodoModal と同じ「PTY モードで実行」「Remote Control を有効化」の 2 つのチェックボックスを追加。これまで TodoModal 経由でしか toggle を出せていなかったため、通常の作成フローからは PTY / Remote Control を有効化できない状態だった。 - useState で ptyEnabled / remoteControlEnabled を追加 - PTY を OFF にしたとき RC が残っている場合に自動クリアする useEffect を追加 - createMut.mutateAsync と dependency 配列に両フィールドを追加 - TodoModal と同じスタイル (emerald / indigo 系) の label を worktree チェックの直下に配置
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTodoManager.tsx に新しい composer state として Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
PR #278 で TodoModal (ダイアログ版) に追加した「PTY モードで実行」「Remote Control を有効化」の2つのチェックボックスが、TodoManager 内のインライン composer (「新しい TODO」カード) には入っていなかった。通常の TODO 作成フロー (Agent Manager 画面) からは composer を使うため、その経路では PTY / Remote Control を有効化できない状態だった。
変更内容
TodoManager.tsxの composer セクションにptyEnabled/remoteControlEnabledの useState を追加createMut.mutateAsyncの呼び出しと dependency array に両フィールドを追加確認済み
Test plan
-p経路で起動することSummary by CodeRabbit
新機能