upstream取り込み: v1 terminal dimensions sync fix (#3545, 手動移植)

[MocA-Love]

概要

upstream から v1 terminal の backend dimension 同期 fix を取り込む PR。behind 1 → 0（PR8 と合わせて）。

取り込み commit

SHA	内容	分類
867ef8746	fix(desktop): sync v1 terminal dimensions to backend on connect (superset-sh#3545) — 1 file, +13	要検討（手動移植）

fork 適応修正（手動移植の理由）

fork は useTerminalLifecycle.ts の cold-restore 処理周りで upstream と diverge しているため、straight cherry-pick は git apply fail。

移植内容:

1. syncBackendDimensions helper を const { xterm, fitAddon, searchAddon } = cached; 直後に追加（upstream と同じ位置）
2. 1st createOrAttach.onSuccess で setConnectionError(null) 直後に呼び出し（upstream と同じ）
3. 2nd createOrAttach.onSuccess で setConnectionError(null) 直後に呼び出し（upstream は markTerminalSessionReady(paneId) 直後だが、fork はそれを cold-restore 対応で deferred しているため setConnectionError 直後へ移動）

Codex pre-review

Yes（全5項目）:

• closure scope OK
• 2nd site placement 妥当（cold-restore でも動作整合、backend resize は存在しないセッションに対して "not found" で握り潰される実装）
• clientWidth/Height === 0 ガード妥当
• fitAddon.fit() 重複は意図的 2-phase（attach 時 + settled layout 後）、副作用許容範囲

検証

• typecheck: 全 26 タスク pass
• lint: 3件 baseline、regression なし

テストチェックリスト

• preset tab / 新規 workspace 作成で v1 terminal 起動 → shell prompt が正しい幅で折り返されるか（従来は stale defaults で折り返し誤り）
• cold-restore 復帰で regression なし

[coderabbitai]

Warning

Rate limit exceeded

@MocA-Love has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 18 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 55 minutes and 18 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c79a6707-56f7-4912-abba-198af627e78a

📥 Commits

Reviewing files that changed from the base of the PR and between 53a0018 and a142d28.

⛔ Files ignored due to path filters (1)

• bun.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/hooks/useTerminalLifecycle.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch upstream-merge/pr9-terminal-dim-sync

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}