Skip to content

upstream取り込み: Create Section Below を top-level に昇格 (#3537)#308

Merged
MocA-Love merged 1 commit intomainfrom
upstream-merge/pr3_5-create-section-below
Apr 17, 2026
Merged

upstream取り込み: Create Section Below を top-level に昇格 (#3537)#308
MocA-Love merged 1 commit intomainfrom
upstream-merge/pr3_5-create-section-below

Conversation

@MocA-Love
Copy link
Copy Markdown
Owner

概要

upstream から sidebar context menu 改善 (superset-sh#3537) を取り込む PR です。behind 5 → 4。

取り込み commit

SHA タイトル 分類
78b7dc839 feat(desktop): promote 'Create Section Below' to top-level on workspace menu (superset-sh#3537) 確実に安全(独立)

fork 適応修正

なし(clean cherry-pick)。3 files, +84/-35。

依存関係

Codex pre-review

  • 初回: No(section 内 workspace 上での挙動を fork 独自と誤認)
  • 再レビュー: Yes(section/grouping は upstream 機能で fork 独自なし、現挙動は upstream 共通仕様で本 PR 起因の回帰なし)

テストチェックリスト

  • dashboard sidebar の workspace context menu に "Create Section Below" が top-level で表示されるか
  • section 内 workspace / section 外 workspace 双方で動作確認

…ce menu (superset-sh#3537)

* feat(desktop): promote "Create Section Below" to top-level on workspace menu

The workspace context menu previously hid section creation inside the
"Move to Section" submenu, and the new section always appended to the
end of the project — making "create" and "move" feel like the same
action. Promote section creation to a top-level item, inserting an
empty section directly below the right-clicked workspace so it matches
the label, and leave "Move to Section" as a list of existing sections
(hidden entirely when none exist).

* refactor(desktop): separate "Create Section Below" from "Move to Section" with divider
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Warning

Rate limit exceeded

@MocA-Love has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 20 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 20 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 01269ff9-fb55-4120-9fa9-4ec913bae5c4

📥 Commits

Reviewing files that changed from the base of the PR and between 82abdf3 and a9b5dd2.

📒 Files selected for processing (3)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceContextMenu/DashboardSidebarWorkspaceContextMenu.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/hooks/useDashboardSidebarWorkspaceItemActions/useDashboardSidebarWorkspaceItemActions.ts
  • apps/desktop/src/renderer/routes/_authenticated/hooks/useDashboardSidebarState/useDashboardSidebarState.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upstream-merge/pr3_5-create-section-below

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MocA-Love MocA-Love merged commit 1012b71 into main Apr 17, 2026
6 checks passed
MocA-Love added a commit that referenced this pull request Apr 17, 2026
Upstream commits processed (cherry-picked, then adapted where needed):

- 07c1ee0 fix(desktop): Cmd+O firing open-in twice on v1 workspace route (superset-sh#3511)
  → PR #302 (with fork tearoff-window adaptation for Cmd+O)
- 4a1f41a chore(deps): upgrade tanstack/db + electric, drop durable-streams patch (superset-sh#3509)
  → PR #303 (fork keeps fstream patch)
- a3df489 feat(desktop): v2 PR checkout via widened checkout procedure (superset-sh#3525)
  → PR #304 (clean)
- c504a50 feat(desktop): v2 file editor — foundation, views, and stability pass (superset-sh#3526)
  → PR #310 (foundation: 58 files path-checkout)
  → PR #311 (adaptation: 20 files manual port with SpreadsheetViewer/memo/fork-hotkeys preserved)
- 78b7dc8 feat(desktop): promote "Create Section Below" to top-level on workspace menu (superset-sh#3537)
  → PR #308

Record merge so upstream/main..main shows 0 behind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants