fix(desktop): ラベル統一 + スケジュール編集干渉 + IME Enter + ステータスPopover#269
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 53 minutes and 9 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 Walkthrough概要ClaudeRuntimePickerおよびTodoManagerコンポーネント内の日本語ラベルテキストを英語に変更しました。「Claude モデル」を「Model」に、「思考 effort」を「Effort」に統一する国際化対応です。コンポーネントロジックや機能は変更されていません。 変更内容
推定コードレビュー工数🎯 1 (Trivial) | ⏱️ ~3 minutes 関連する可能性のあるPR
兎からの応援詩
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
- ScheduleListRow の編集/削除メニューが Dialog と干渉して一瞬で閉じる問題を修正 (setTimeout で open を遅延、modal=false) - TodoManager の Enter 送信で IME 変換確定時の誤送信を防止 (isComposing チェック) - ヘッダーの Claude/Codex ステータスをホバー起動 Tooltip からクリック起動 Popover に変更し、中のリンクからサイトを開く形に
MocA-Love
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e0b44240e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex レビュー指摘対応。onSelect 内の e.preventDefault() を外すことで Radix の既定クローズ挙動を残しつつ、setTimeout で Dialog を次 tick に 遅延して Outside-click 競合も回避。
1 participant
概要
変更点
ClaudeRuntimePicker,TodoManager,ScheduleListRowの表示を Model / Effort にScheduleListRowで 3 点メニュー → 編集を押すとダイアログが一瞬で閉じる / 動作が不安定な問題を修正DropdownMenuのmodal={false}+DropdownMenuItemのonSelectでe.preventDefault()+setTimeout(onEdit, 0)で Dialog オープンを次 tick に遅延TodoManager.tsxの送信入力欄とリネーム入力で、e.nativeEvent.isComposingを見て IME 変換中は Enter を無視status.claude.com を開く等のリンクをクリックで外部ブラウザオープン確認
bun run lint:fixcd apps/desktop && bun run typecheckCloses #268