Skip to content

feat(desktop): カスタム通知音の削除 / リネーム機能#261

Merged
MocA-Love merged 1 commit into
mainfrom
feat/258-ringtone-delete-rename
Apr 17, 2026
Merged

feat(desktop): カスタム通知音の削除 / リネーム機能#261
MocA-Love merged 1 commit into
mainfrom
feat/258-ringtone-delete-rename

Conversation

@MocA-Love
Copy link
Copy Markdown
Owner

概要

カスタム通知音(YouTube クリップ含む)を削除・リネームできるようにします。Issue #258 の追加対応です。

実装内容

  • apps/desktop/src/main/lib/custom-ringtones.tsdeleteCustomRingtone() を追加(オーディオファイル + メタデータを除去)
  • tRPC ルーターに ringtone.deleteCustomringtone.renameCustom を追加
  • RingtoneCard の左上に3点ドロップダウンを追加(カスタム通知音のみ表示)
  • RenameRingtoneDialog を新規追加
  • 削除時に CUSTOM_RINGTONE_ID が選択中だったらビルトイン1番目に自動切替

テスト計画

  • カスタム通知音カードのメニューから Rename → 名前が更新される
  • カスタム通知音カードのメニューから Delete → ファイル + メタデータが削除される
  • Delete 時に確認ダイアログが出る
  • 削除後にカスタムカードが消える
  • 削除時に選択中だった場合、別の通知音に切り替わる

Refs #258

カスタム通知音カードに3点メニューを追加し、Rename と Delete
を選べるようにする。

- main: deleteCustomRingtone を新設、ファイル + メタデータを除去
- tRPC: ringtone.deleteCustom / ringtone.renameCustom を追加
- UI: RenameRingtoneDialog 新規追加、RingtoneCard に
  ドロップダウンメニュー(カスタムのみ)を追加
- 削除時に CUSTOM_RINGTONE_ID が選択中ならビルトインに自動切替

Refs #258
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Warning

Rate limit exceeded

@MocA-Love has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 19 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 19 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c4a8a59-f3ac-4709-96d1-61cfbeedcfe1

📥 Commits

Reviewing files that changed from the base of the PR and between 8489ea2 and 7afa3b8.

📒 Files selected for processing (5)
  • apps/desktop/src/lib/trpc/routers/ringtone/index.ts
  • apps/desktop/src/main/lib/custom-ringtones.ts
  • apps/desktop/src/renderer/routes/_authenticated/settings/ringtones/components/RingtonesSettings/RingtonesSettings.tsx
  • apps/desktop/src/renderer/routes/_authenticated/settings/ringtones/components/RingtonesSettings/components/RenameRingtoneDialog/RenameRingtoneDialog.tsx
  • apps/desktop/src/renderer/routes/_authenticated/settings/ringtones/components/RingtonesSettings/components/RenameRingtoneDialog/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/258-ringtone-delete-rename

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MocA-Love
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MocA-Love MocA-Love merged commit 9efd241 into main Apr 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant