Skip to content

fix(desktop): YouTube ringtone の yt-dlp/ffmpeg を絶対パスで解決#260

Merged
MocA-Love merged 1 commit into
mainfrom
fix/258-youtube-binary-resolve
Apr 17, 2026
Merged

fix(desktop): YouTube ringtone の yt-dlp/ffmpeg を絶対パスで解決#260
MocA-Love merged 1 commit into
mainfrom
fix/258-youtube-binary-resolve

Conversation

@MocA-Love
Copy link
Copy Markdown
Owner

概要

PR #259 でマージした YouTube 通知音機能で、Homebrew でインストール済みの ffmpeg / ffprobe が「Missing required tool(s)」と判定されてしまう問題を修正します。

原因

GUI から起動した Electron プロセスでは login-shell PATH の取り込みが不安定で、spawn に渡した env 経由の PATH 解決でバイナリを見つけられないケースがありました。

修正

  • 必要なバイナリ (yt-dlp / ffmpeg / ffprobe) を env.PATH と /opt/homebrew/bin 等のフォールバックディレクトリから絶対パスで解決
  • spawn には絶対パスを渡し、yt-dlp には --ffmpeg-location を明示
  • 解決失敗時のエラーメッセージに「ログインシェル PATH を確認」と追記

テスト計画

  • Homebrew でインストールした yt-dlp / ffmpeg が GUI 起動時にも検出される
  • From YouTube から通知音をクリップ生成できる

Refs #258

GUI 起動の Electron プロセスでは login shell PATH の取り込みが
不安定で、ffmpeg/ffprobe がインストール済みでも見つからないこ
とがあった。

- 必要なバイナリを env.PATH と /opt/homebrew/bin 等のフォール
  バックディレクトリから絶対パスで解決
- spawn には絶対パスを渡し、yt-dlp には --ffmpeg-location を
  明示
- 解決失敗時のエラーメッセージに「ログインシェル PATH を確認」
  と追記
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Warning

Rate limit exceeded

@MocA-Love has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 12 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 12 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e37182d2-7fd7-4634-91ca-7e7d02d197cc

📥 Commits

Reviewing files that changed from the base of the PR and between b5b84d2 and 6986064.

📒 Files selected for processing (1)
  • apps/desktop/src/main/lib/youtube-ringtone.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/258-youtube-binary-resolve

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MocA-Love MocA-Love merged commit 8489ea2 into main Apr 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant