Conversation
The "Right sidebar open view width" setting only took effect for 3 call sites (Files sidebar, Changes view file click, Changes line jump). Every other flow that opens a file via the split-pane path (`addFileViewerPane` without `openInNewTab`) fell back to the default split percentage, so users reported the setting silently not being applied. Pass `useRightSidebarOpenViewWidth: true` from all remaining call sites: Search/Problems jump-to-line, Chat v1/v2 attachments and mentioned-file clicks, chat markdown file links, tool call open-file / open-diff actions, terminal file link clicks, Command Palette and keyword search selections, go-to-definition inside the file viewer, reference graph node double-click, VS Code extension open-file / diff sync, commit details panel file click, Create-Memo buttons (EmptyTabView / GroupStrip), and the workspace pending-intent auto open.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (19)
📝 WalkthroughWalkthroughこのプルリクエストでは、ファイルビューアペインを開く複数の呼び出し箇所（ Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Right sidebar open view width setting (Settings → General) controls the initial width of new file/diff views when a file is opened as a split pane. It was only honored in 3 call sites — the Files sidebar double-click and Changes view file / line-jump handlers — so users reported the setting silently not applying most of the time.
Technically, the
splitPercentagecomputed from this setting is only applied insideaddFileViewerPanewhen theuseRightSidebarOpenViewWidthoption istrueon the split-pane creation path (stores/tabs/store.ts). Every other call site fell back toDEFAULT_FILE_VIEWER_SPLIT_PERCENTAGE.This PR passes
useRightSidebarOpenViewWidth: truefrom every remainingaddFileViewerPanecall site that can hit the split-pane path, so the setting now applies uniformly regardless of origin.Flows covered
RightSidebar/index.tsxhandleOpenFileAtLine)useFileLinkClick)openFileInPaneandopenDiffInPaneIPC?file=...)Already-correct call sites (
FilesView,RightSidebar handleFileOpenPane,RightSidebar handleChangesOpenFileAtLine) are untouched.No behavior change for flows that open a file in a new tab (
openInNewTab: true) or reuse an existing preview pane — those paths do not create a new split and ignore this option by design.Test plan
new-tabbun run lint✅bun run typecheck✅Summary by CodeRabbit
リリースノート