feat: Propagate InterruptedException during feed loading #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aababilov
force-pushed
the
InterruptedException
branch
2 times, most recently
from
624361b
to
4232772
Compare
IBM wrote an article on the subject: http://web.archive.org/web/20210201071452/https://www.ibm.com/developerworks/java/library/j-jtp05236/index.html If throwing InterruptedException means that a method is a blocking method, then calling a blocking method means that your method is a blocking method too, and you should have a strategy for dealing with InterruptedException. Often the easiest strategy is to throw InterruptedException yourself, as shown in the putTask() and getTask() methods in Listing 1. Doing so makes your method responsive to interruption as well and often requires nothing more than adding InterruptedException to your throws clause.
aababilov
force-pushed
the
InterruptedException
branch
2 times, most recently
from
525af47
to
ff2757b
Compare
lionel-nj
reviewed
Apr 23, 2021
core/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFeedLoader.java
Show resolved
Hide resolved
lionel-nj
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Thanks @aababilov for working on this. Will keep the documentation you attached handy so that we can make sure to replicate this mechanism if needed in the future.
|
Thanks for review! Could you merge it? I still don't have permissions to do that on my own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InterruptedException is a sign to immediately stop validation. We may not just add a notice and keep on validating.
IBM wrote an article on the subject:
http://web.archive.org/web/20210201071452/https://www.ibm.com/developerworks/java/library/j-jtp05236/index.html
If throwing InterruptedException means that a method is a blocking method, then calling a blocking method means that your method is a blocking method too, and you should have a strategy for dealing with InterruptedException. Often the easiest strategy is to throw InterruptedException yourself, as shown in the putTask() and getTask() methods in Listing 1. Doing so makes your method responsive to interruption as well and often requires nothing more than adding InterruptedException to your throws clause.