feat: included network_id as part of the primary key for fare_leg_rules.txt #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit b02c309 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (8 out of 1602 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
jcpitre
reviewed
Oct 18, 2024
main/src/test/java/org/mobilitydata/gtfsvalidator/table/GtfsFareLegRuleDuplicateKeyTest.java
Outdated
Show resolved
Hide resolved
…txt-to-include-network_id
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit d087d99 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (8 out of 1602 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
…duplicateKeyNoticeWithNetworkIdAsPrimaryKey test
…e-network_id' of github.com:MobilityData/gtfs-validator into 1889-modify-primary-key-for-fare_leg_rulestxt-to-include-network_id
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit ffbe834 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (8 out of 1602 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
LGTM! |
…txt-to-include-network_id
qcdyx
deleted the
1889-modify-primary-key-for-fare_leg_rulestxt-to-include-network_id
branch
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 797ee3d 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (8 out of 1602 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1889
gtrans-ca-us.zip
Expected behavior:
test dataset:
Before:
After:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything