feat: 1883 flex modify stop without stop time to exclude stops associated with a used location group #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-exclude-stops-associated-with-a-used-location_group
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit d98081a 📊 Notices ComparisonNew Errors (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (1 out of 1596 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1596 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
…-exclude-stops-associated-with-a-used-location_group
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit bc69b69 📊 Notices ComparisonNew Errors (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (1 out of 1601 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1601 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
|
@qcdyx QA is as expected! |
jcpitre
reviewed
Oct 17, 2024
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/LocationHasStopTimesValidator.java
Outdated
Show resolved
Hide resolved
davidgamez
reviewed
Oct 17, 2024
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/LocationHasStopTimesValidator.java
Outdated
Show resolved
Hide resolved
…-exclude-stops-associated-with-a-used-location_group
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit d494723 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (1 out of 1602 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
lgtm! |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 7014490 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (1 out of 1602 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
jcpitre
approved these changes
Oct 18, 2024
qcdyx
deleted the
1883-flex-modify-stop_without_stop_time-to-exclude-stops-associated-with-a-used-location_group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1883
Expected behavior:
exclude stop_without_stop_time notice if stop_id is part of location_group_stops.txt referenced in stop_times.txt.
Before:
After:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything