Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct links to rule documentation by adding -rule #1629

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

bradyhunsaker
Copy link
Contributor

Summary:

Resolves issue #1608 and duplicate issue #1626.

Links are currently broken. They go to the right web page but not to the individual rule on the page. This corrects the links, which just need "-rule" added to them.

Expected behavior:

The generated report.html file should have a correct link for each rule it lists, going directly to that rule's section of the documentation.

I tested on a sample report and confirmed the new links work.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [X ] Run the unit tests with gradle test to make sure you didn't break anything
  • [X ] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • [X ] Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcpitre jcpitre merged commit 33edab9 into MobilityData:master Jan 9, 2024
333 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants